react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

Published 20 hours ago • verified publisher icon callstack

fix(text-input): parent scroll with text input height

Open seb-zabielski opened this issue 1 year ago • 2 comments

Platform: Android only

Motivation

This pull request fixes two bugs that are related to each other.

  1. TextInput mode="outlined" with height style property blocks parent scroll.

https://github.com/callstack/react-native-paper/assets/165782545/e7b8e7b8-157e-41d0-bbf0-8673a5d01466

  1. mode="outlined" Left/right suffix is not correctly aligned to input when height style is provided Screenshot 2024-05-28 at 12 03 52 2

  2. mode="flat"(default) blocks scrolling of the parent with a large font. The bug can be reproduced in the example app “Flat input large font”.

https://github.com/callstack/react-native-paper/assets/165782545/20bf336d-9ed2-4cad-853e-82e8e0159641

Related issue

#1556, #4390,

Test plan

  1. To test issue 1 and 2 run example app and set height style of the Text input prop
  2. To test issue 3 run example app, and try to scroll starting from Flat input large font

Recording below shows result with the fix:

https://github.com/callstack/react-native-paper/assets/165782545/4a9ef63b-7a7a-42e1-ad99-4ed63dea281a

seb-zabielski avatar May 28 '24 10:05 seb-zabielski

Hey @seb-zabielski, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

callstack-bot avatar May 28 '24 10:05 callstack-bot

LGTM

gedu avatar Jun 04 '24 08:06 gedu