react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

[Feature Request] `SearchBar` loading property

Open fabriziocucci opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? No, but it would be nice if the SearchBar component could expose a loading property.

Describe the solution you'd like Ideally, when loading={true}, an ActivityIndicator could be shown in place of the clear icon (like Google Maps does).

Describe alternatives you've considered N/A

Additional context Screenshot from Google Maps below:

image

fabriziocucci avatar Jun 26 '22 18:06 fabriziocucci

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.dev link or link to a GitHub repo under your username).

Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

github-actions[bot] avatar Jun 26 '22 18:06 github-actions[bot]

Couldn't find version numbers for the following packages in the issue:

  • react-native
  • react-native-paper
  • react-native-vector-icons

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

github-actions[bot] avatar Jun 26 '22 18:06 github-actions[bot]

Hey @fabriziocucci, I think that makes sense. Would you like to add the loading property to the Searchbar (e.g. similarly to the one existing in Button) covered by the unit test?

lukewalczak avatar Jun 26 '22 20:06 lukewalczak

Hey @lukewalczak, thanks for the prompt reply, happy to give it a try this week! :)

fabriziocucci avatar Jun 27 '22 07:06 fabriziocucci

I installed the package in the most up-to-date version but I'm still seeing the old material design design, how do I see the updated material design you ?

gustavohbeg avatar Jun 29 '22 22:06 gustavohbeg

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.

github-actions[bot] avatar Aug 03 '22 02:08 github-actions[bot]

Solved by: https://github.com/callstack/react-native-paper/pull/3322

lukewalczak avatar Aug 22 '22 11:08 lukewalczak