construct-style-sheets icon indicating copy to clipboard operation
construct-style-sheets copied to clipboard

Add ESM support

Open Lodin opened this issue 3 years ago • 4 comments

Resolves #93

Lodin avatar Jan 31 '22 08:01 Lodin

@calebdwilliams, I wonder what would be better: to use .mjs in module field or to remove module field completely in favor of exports field? What do you think?

Lodin avatar Jan 31 '22 10:01 Lodin

Codecov Report

Merging #104 (f4208ad) into main (e6c5177) will not change coverage. The diff coverage is n/a.

:exclamation: Current head f4208ad differs from pull request most recent head b4b294e. Consider uploading reports for the commit b4b294e to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files           5        5           
  Lines         189      189           
  Branches       32       32           
=======================================
  Hits          174      174           
  Misses          4        4           
  Partials       11       11           
Flag Coverage Δ
unittests 92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6c5177...b4b294e. Read the comment docs.

codecov-commenter avatar Jan 31 '22 12:01 codecov-commenter

@Lodin in my experience exports is spotty until everything adopts [email protected]. I’d definitely mark that as a to-do but maybe not right away unless it’s absolutely needed.

calebdwilliams avatar Jan 31 '22 13:01 calebdwilliams

Also @Lodin let me know when this is final and I’ll try it out locally.

calebdwilliams avatar Jan 31 '22 13:01 calebdwilliams