Caleb White

Results 344 comments of Caleb White

> The resulting errors are exactly the same as before. As I have outlined in the second update to the description, the update from larastan v2.8.1 to v2.9.0 is indeed...

@canvural, I don't think the first test file actually gets tested because the minimum version is L9.52: https://github.com/larastan/larastan/blob/52b51412b28755e2fb759e02de0e3107b741f599/tests/Type/CollectionDynamicReturnTypeExtensionsTest.php#L18-L22 Also, why do we have two similarly named files? - tests/Type/CollectionDynamicReturnTypeExtensionsTest.php -...

@canvural, all tests are passing---I essentially updated the `CollectionGenericStaticMethodDynamicMethodReturnTypeExtension` to look at the Enumerable class instead of the SupportCollection interface. Not sure if this is the best way to solve...

Also, there's a similar class that might need to be updated as well? - CollectionGenericStaticMethodDynamicStaticMethodReturnTypeExtension

@canvural, are the dynamic return type extensions still required or can we achieve the same effect with conditional return types (which should already exist)? ![image](https://github.com/larastan/larastan/assets/4176520/fece911b-3963-4a48-a4b0-6a14f09ba8f2)

marking as draft until I can take a better look at this next week

@dododedodonl, As long as the Models are declaring the schema as part of the table name: ```php class Invoice extends Model { protected $table = 'accounting.invoices'; } ``` and migrations...

> Only difference from your example I see is that I use the getTable() method to set the schema. That shouldn't matter though because Larastan directly calls the model instance's...

Marking as draft until #1831 is merged

@canvural, I've rebased and tests are passing, can this be merged? This just switches the checks around so that if there's an explicit cast for a date it will use...