Caleb White

Results 344 comments of Caleb White

It looks like https://github.com/larastan/larastan/pull/2271 was duplicate PR that was merged and conflicted with this, so this has morphed into more of a refactoring PR

CI failures appear to be on `master` and unrelated to the changes in this PR: https://github.com/laravel/framework/actions/runs/11836108052

This sounds like a framework issue instead of a Larastan issue, but here's how I autoload all of our commands so they don't need to be manually loaded---they just have...

Ah, looks like it has to do with the application resolution in https://github.com/larastan/larastan/blob/3.x/src/Internal/ConsoleApplicationResolver.php Larastan already boots the container, we should be using that instead of trying to manually resolve it

@nikic, that is illegal: https://3v4l.org/Prr6W

Ah that makes sense, I've updated the logic to skip over unpacks. For the `$position` parameter, do you think this should be 1-based or 0-based? ```php $arg = $node->getArg('bar', 1);...

@nikic, just wanted to touch base---do you think this will suffice?