Caleb Cartwright
Caleb Cartwright
There's a few additional things we'll need to consider: * The underlying ty can be `Self` or something that dereferences to it. That means we need to account for some...
Think this enumeration should serve as a good reference https://doc.rust-lang.org/stable/reference/items/associated-items.html#methods: ```rust // Examples of methods implemented on struct `Example`. struct Example; type Alias = Example; trait Trait { type Output;...
Thanks. I don't have enough time to really go through this but a quick glance at b7b1083f0da6efc11c4298de5dd0417ce1434439 makes me wonder whether that commit may also be changing logic? It certainly...
Can you try running with the `--verbose` flags? That should tell you which config file, if any, is getting picked up. Remember that rustfmt doesn't (currently) support aggregated configs, so...
Need to think on this for a bit to determine whether it meets the criteria of a true bug or if it's at risk of violating our stability guarantee and...
Thank you for the PR. Haven't had a chance to look at the diff and given the current backlog it may be a bit before we get to it. However,...
I think it would probably be worth some bikeshedding on the variant name. This might suffice in isolation, but we need to think about the variant name in the context...
Something like `NoncrateCrate` is perhaps more descriptive but a real mouthful :thinking:
Thanks for the updates! I may have a very minor nit or two as a final review pass, but I think we're otherwise in good shape. I want to think...
> I' m using shields.io in a read.me file on github. But got the error `Unable to select next Github token from pool` Try [this url for example](https://img.shields.io/github/commit-activity/m/JohnyP36/Personal-List?label=Commits&color=succes&style=plastic) @JohnyP36 that's...