cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

perf: remove platform from lib

Open keithwillcode opened this issue 8 months ago • 3 comments

What does this PR do?

@calcom/platform should be able to import @calcom/lib, not the other way around.

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Ensure all checks pass

keithwillcode avatar Mar 14 '25 07:03 keithwillcode

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Perf/remove platform from lib". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Mar 14 '25 07:03 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 9:47am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 9:47am

vercel[bot] avatar Mar 14 '25 07:03 vercel[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Mar 29 '25 00:03 github-actions[bot]

Closing since @supalarry mentioned @SomayChauhan will be working on a refactor that handles this.

keithwillcode avatar Apr 15 '25 15:04 keithwillcode