cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: preview Taurify for desktop

Open lucasfernog-crabnebula opened this issue 1 year ago • 12 comments

This pull request introduces taurify, a service for developing and distributing desktop and mobile apps using a Web frontend. It can be seen as a ToDesktop alternative.

To try this out, run npx taurify dev in the apps/web directory.

This initial demonstration includes a tray icon populated with upcoming events and the cal:// deep link, though it is capable of much more. We will share documentation soon.

lucasfernog-crabnebula avatar Oct 28 '24 14:10 lucasfernog-crabnebula

@lucasfernog-crabnebula is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 28 '24 14:10 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 28 '24 14:10 CLAassistant

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedical.js@​1.5.01001001007770
Added@​formkit/​auto-animate@​1.0.0-beta.51001008481100

View full report

socket-security[bot] avatar Oct 28 '24 14:10 socket-security[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (05/01/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Oct 28 '24 14:10 graphite-app[bot]

hey @lucasfernog-crabnebula, can you please sign CLA ?

Praashh avatar Oct 28 '24 16:10 Praashh

already signed :) now we need @atilafassina

lucasfernog-crabnebula avatar Oct 28 '24 20:10 lucasfernog-crabnebula

already signed :) now we need @atilafassina

Signed!!! 🎉🔥

atilafassina avatar Oct 28 '24 20:10 atilafassina

can you make a loom video?

PeerRich avatar Oct 29 '24 10:10 PeerRich

my dev environment is super slow (i'm not sure if that's expected) but here is a quick demo https://drive.google.com/file/d/1SK_BpRsaGtq__Qo_s32riQ5ZiWxg-hm6/view?usp=sharing

lucasfernog-crabnebula avatar Oct 30 '24 16:10 lucasfernog-crabnebula

@sean-brydon @eunjae-lee @zomars can you please look at this before we move forward? 🙏

keithwillcode avatar Nov 27 '24 16:11 keithwillcode

hey guys I just got back from vacation and fixed some conflicts. Let me know if you have any questions.

lucasfernog-crabnebula avatar Dec 02 '24 22:12 lucasfernog-crabnebula

hey guys I just got back from vacation and fixed some conflicts. Let me know if you have any questions.

Hey @lucasfernog-crabnebula I tried to run it locally. After the login page, it's blank. Am I doing something wrong?

(cd apps/web && npx taurify dev)

Screenshot 2024-12-11 at 17 10 29

Screenshot 2024-12-11 at 17 08 13

I don't know the scope of this PR, but I've found the app icon a bit bigger and blury:

image

Screenshot 2024-12-11 at 17 12 06

eunjae-lee avatar Dec 11 '24 16:12 eunjae-lee

@eunjae-lee you can try opening the inspector to see what is the problem by either right clicking in the app window or by pressing Command + Option + I, looks like the frontend crashed somewhere.

I'll see what I can do about the app icon.

lucasfernog-crabnebula avatar Dec 17 '24 10:12 lucasfernog-crabnebula

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

socket-security[bot] avatar Dec 17 '24 16:12 socket-security[bot]

I've fixed the blurry macOS icon (it was only a development mode issue), should be good now. Let me know if you can find any errors in the console.

lucasfernog-crabnebula avatar Dec 17 '24 16:12 lucasfernog-crabnebula

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jan 01 '25 00:01 github-actions[bot]

I've fixed the blurry macOS icon (it was only a development mode issue), should be good now. Let me know if you can find any errors in the console.

Hi @lucasfernog-crabnebula sorry for the late response.

Here's what i've got:

https://github.com/user-attachments/assets/2ff6f70a-88f8-41f0-9881-9266c9f30991

eunjae-lee avatar Jan 07 '25 15:01 eunjae-lee

I've fixed the blurry macOS icon (it was only a development mode issue), should be good now. Let me know if you can find any errors in the console.

Hi @lucasfernog-crabnebula sorry for the late response.

Here's what i've got:

Screenshot.2025-01-07.at.16.29.26.mp4

looks like the login isn't redirecting to localhost:3000/event-types and window.location.href is probably about:blank (or the app is failing to load somehow? that is weird). I also don't see all those CORS issues you have. Which macOS version are you using?

image

image

lucasfernog-crabnebula avatar Jan 08 '25 12:01 lucasfernog-crabnebula

@lucasfernog-crabnebula are you still working on it , are the issues fix (if any) ?

TusharBhatt1 avatar Feb 11 '25 06:02 TusharBhatt1

I did not make any new change after the discussion about the macOS issue - I think it would be valuable to get feedback from other macOS users

lucasfernog-crabnebula avatar Feb 11 '25 10:02 lucasfernog-crabnebula

I did not make any new change after the discussion about the macOS issue - I think it would be valuable to get feedback from other macOS users

Thanks for waiting. I was occupied with other tasks. You gave me a hint, and it was because I enabled "Organizations" in my local .env file, by having

ORGANIZATIONS_ENABLED=1

and

NEXT_PUBLIC_WEBAPP_URL='http://app.cal.local:3000'

After resetting them, now it works.

eunjae-lee avatar Feb 12 '25 09:02 eunjae-lee

what else can I do here to move this further?

lucasfernog-crabnebula avatar Feb 15 '25 17:02 lucasfernog-crabnebula

E2E results are ready!

github-actions[bot] avatar May 01 '25 17:05 github-actions[bot]

@lucasfernog-crabnebula checks failing

CleanShot 2025-05-01 at 19 49 51@2x

PeerRich avatar May 01 '25 18:05 PeerRich

some failing check!

retrogtx avatar May 13 '25 05:05 retrogtx

@lucasfernog-crabnebula thanks for the pr, some merge conflicts are still there. Due to inactivity for a long time , closing this pr for now . Feel free to reopen it if you want to continue your work on it.

Devanshusharma2005 avatar Jun 30 '25 04:06 Devanshusharma2005