pyCGM icon indicating copy to clipboard operation
pyCGM copied to clipboard

pycgmStatic Refactor

Open jm786 opened this issue 4 years ago • 0 comments

Summary of PR:

Made appropriate changes to render pycgmStatic Pep 8 compliant. Refactored four functions:

  • IADCalculation --> iad_calculation
  • staticCalculationHead --> calculate_head_angle
  • footJointCenter --> foot_joint_center

Also added pyenv to .gitignore and a init.py for the new pycgm folder.

What issues does this PR close:

pycgmStatic Pep 8 Compliance pycgmStatic Refactor (partially)

What files were changed and what changes were made?

pycgm/static.py: Refactored the aforementioned functions and made appropriate pep8 changes. pycgm/tests/test_static_axis.py: Skipped non-refactored functions and refactored appropriate tests. pycgm/tests/test_static_utils.py: Skipped non-refactored functions and refactored appropriate tests. .gitignore: added .python-version.

Does your PR (check all that applies):

  • [ ] Add documentation
  • [x] Change/Remove documentation
  • [ ] Add tests
  • [x] Change/Remove tests
  • [ ] Add code
  • [x] Change/Remove code
  • [x] Fix formatting

Are there any errors/relevant logs in your code?

None

How has this been tested?

Used pytest, flake8.

jm786 avatar Apr 22 '21 03:04 jm786