pyCGM
pyCGM copied to clipboard
Refactor pycgmKinetics.py to kinetics.py
Summary of PR:
This PR refactors pycgmKinetics.py. This PR removes and fixes any functions that can be replaced with the numpy version.
What issues does this PR close:
PEP8 formatting Refactoring functions
What files were changed and what changes were made?
init.py - created to run pytest kinetics.py - fixed PEP8 formatting, removed vector() which is similar to np.subtract() (and fixed the differences in the rest of the code) and removed add() which is the same as np.add(). Combined smaller functions into get_kinetics(). Changed find_L5 function to take in a 4x4 matrix for the axis test_kinetics.py - Removed tests for functions that do not exist anymore, changed unit tests to round to 5 decimal places.
Does your PR (check all that applies):
- [ ] Add documentation
- [x] Change/Remove documentation
- [ ] Add tests
- [x] Change/Remove tests
- [ ] Add code
- [x] Change/Remove code
- [x] Fix formatting
Are there any errors/relevant logs in your code?
No
How has this been tested?
Run doctests/pytest