caddy icon indicating copy to clipboard operation
caddy copied to clipboard

Add mod_ssl-like Placeholder Support for Server and Client Certificates in Caddy

Open Ko496-glitch opened this issue 10 months ago • 4 comments
trafficstars

This pull request introduces functionality similar to Apache's mod_ssl by adding support for dynamic placeholders for server and client certificates in Caddy. The implementation addresses the following:

1)Dynamic Placeholder Population:

Populates placeholders for both server and client certificates during TLS connections, enabling detailed certificate information to be accessed in configurations (e.g., headers, logs).

2)Support for Default Values:

Ensures placeholders return meaningful default values (e.g., null or descriptive strings) when client certificates are not provided (e.g., in non-mTLS scenarios).

3)Centralized Logic:

Introduced a new function, handleMTLSEnabledWithExport, to handle placeholder population efficiently, reducing redundancy and improving maintainability.

Ko496-glitch avatar Jan 09 '25 18:01 Ko496-glitch

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 09 '25 18:01 CLAassistant

@mohammed90 just checking in too see if everything for the PR looks good ?

Ko496-glitch avatar Jan 12 '25 22:01 Ko496-glitch

@mohammed90 just checking in too see if everything for the PR looks good ?

At first glance, it looks fine, but I haven't had the time to review it thoroughly. We'll get to it.

mohammed90 avatar Jan 13 '25 07:01 mohammed90

#6713

Ko496-glitch avatar Jan 15 '25 00:01 Ko496-glitch