FEATURE: [indicator] adding a bunch of new v2 indicators

[go-dockly]

trafficstars

[bbgokarma-bot]

Hi @go-dockly,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 4869 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

-- If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best, KarmaBot

[bbgokarma-bot]

Re-estimated karma: this pull request may get 9820 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 9931 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 10340 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 10633 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 11162 BBG

[c9s]

this PR is getting too big to merge, would you mind to split them and maybe we can merge some changes, like the csv source package, and the kline csv readers, or maybe the extended slice methods.

[bbgokarma-bot]

Re-estimated karma: this pull request may get 11026 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 11031 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 11195 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 11654 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 11600 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 11650 BBG

[c9s]

There are too many files, like 140+ files that I could not review all files in one round, will continue the review later.

Since you're the first-time contributor, it would be nice if you can submit a pull request with a small change, so that the CI could be executed for your later PRs.

[c9s]

Or, maybe you can pull out the csvsource changes to one PR, I've reviewed these csvsource file changes.

[bbgokarma-bot]

Re-estimated karma: this pull request may get 8952 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 8224 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 8229 BBG

[go-dockly]

This build is failing due to the go.mod specified compiler v1.18. Can we bump to latest go please?

[c9s]

let’s go with go 1.20

go-dockly @.***>於 2023年11月3日 週五，22:54寫道：

This build is failing due to the go.mod specified compiler v1.18. Can we bump to latest go please?

— Reply to this email directly, view it on GitHub https://github.com/c9s/bbgo/pull/1366#issuecomment-1792589170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMNTSVHFERSR2Y7HOMUELYCUAQVAVCNFSM6AAAAAA6QL6GRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGU4DSMJXGA . You are receiving this because you commented.Message ID: @.***>

[bbgokarma-bot]

Re-estimated karma: this pull request may get 8364 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 8369 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 8379 BBG

[bbgokarma-bot]

Re-estimated karma: this pull request may get 8399 BBG

[go-dockly]

I think this PR is good to merge now

[c9s]

@go-dockly could you please rebase the commits? make it no merge-commits in your PR, thanks

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}