Claire Foster

Just a small note - I've noticed that `match.scm` is used extensively in Base in `macroexpand.scm`. (Though it's been argued elsewhere that code is not well-placed, and should be mostly...

There's a very basic benchmarking script in test/benchmark.jl - does this show any improvement for before vs after this change? If you're working on performance improvements, please do prove to...

Please do benchmark it, all performance work needs benchmarking. Without that, it's easy to code changes which don't matter - needlessly churning the code or introducing complexity. My intuition says...

> My intuition says it would be best to focus on optimizing `is_identifier_start_char` A good part of this was effectively done in #372, and it does have some measurable performance...

I think the changes to `SyntaxNode` are good here and we should do them even if it's too breaking to change `Expr` in Base. JuliaSyntax already contains many such AST...

Heya, I've created a branch https://github.com/JuliaLang/JuliaSyntax.jl/tree/pr-for-Base/537 to make this easier to move into Base To make use of the branch, you can use the following steps: * Clone JuliaLang/julia *...

Go for it! Just bump the Project.toml to 0.3.0 and trigger JuliaRegistrator if you're happy to do that, I think you have permissions?

I can't reproduce this on my dev machine with the example definition of `is_operator_start_char()`. Could the nanosolider machine have a small max stack size? I thought that in practice we'd...

A nesting depth of 1700 is sufficient to cause stack overflow on my machine. For example: ``` julia> make_expr(N) = N == 0 ? UInt32(0) : :(u == $(UInt32(N)) ||...

It's from Tokenize. In JuliaSyntax I've changed the way that function is defined for efficiency and maintainability.