Radio toggles sound bug

[gilbertohasnofb]

trafficstars

The toggles on top of the radio panel (in the SPEAKER section, labelled AUTO, COM1, COM2 etc.) have three possible positions: up, centre and down. They should make sounds only when flicking between these positions, but currently if I click on them when they are in the up position (and can't move upper than that) they are still making sound.

[onox]

It's not just the kma20 instrument that has this problem. Other parts of the cockpit have this as well. The reason is because the sounds are activated via a Nasal binding in the knob animations.

We can either get rid of all these bindings (in tons of files) and then add tons of listeners (lots of work), or (the better fix IMO) fix simgear and add something like an "in-transit-trigger" mode which should work like in-transit except it just plays the sound till the end instead of stopping immediately (which is the case for non-floats). But that's something for 3.8.

[gilbertohasnofb]

Oh, I didn't know that would be so much work, but I totally understand what you wrote. So how can we report this to be fixed in simgear then, onox?

[onox]

So how can we report this to be fixed in simgear then, onox?

You don't have to. I'll write a patch for it after 3.6 gets released.

[gilbertohasnofb]

Okay then, onox! So I will change this issue's milestone to 3.8 and leave it opened as a reminder. Is that fine with you?

[onox]

That sounds good! :+1: (pun intended) :smile:

[gilbertohasnofb]

@onox wrote:

We can either get rid of all these bindings (in tons of files) and then add tons of listeners (lots of work), or (the better fix IMO) fix simgear and add something like an "in-transit-trigger" mode which should work like in-transit except it just plays the sound till the end instead of stopping immediately (which is the case for non-floats).

I think we can simply close this then. Would anyone care to report this to the devel list?

[onox]

I think we should keep the issue open for a little while longer because it hasn't actually been fixed yet. (And someone should write to the mailing list)

[onox]

fix simgear and add something like an "in-transit-trigger" mode which should work like in-transit except it just plays the sound till the end instead of stopping immediately (which is the case for non-floats).

@stuartbuchanan @t3r Is this something that could be added to simgear?

[stuartbuchanan]

What is the type of property?

If it's a bool, can you not get the same effect by simply using once and a statement that's true if the property is true or false?

-Stuart

On Wed, Aug 9, 2017 at 2:31 PM, onox [email protected] wrote:

fix simgear and add something like an "in-transit-trigger" mode which should work like in-transit except it just plays the sound till the end instead of stopping immediately (which is the case for non-floats).

@stuartbuchanan https://github.com/stuartbuchanan @t3r https://github.com/t3r Is this something that could be added to simgear?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/c172p-team/c172p-detailed/issues/362#issuecomment-321255888, or mute the thread https://github.com/notifications/unsubscribe-auth/AL4umEmejS2VWC4R7RF1DEtqoQrz-Uihks5sWbS4gaJpZM4FQ0QA .

[onox]

Many of the properties are integers with values like -1, 0, 1.

[stuartbuchanan]

Hi All,

Could you use the following perhaps?

<

On Fri, Aug 11, 2017 at 10:29 PM, onox [email protected] wrote:

Many of the properties are integers with values like -1, 0, 1.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/c172p-team/c172p-detailed/issues/362#issuecomment-321923388, or mute the thread https://github.com/notifications/unsubscribe-auth/AL4umOKyt3yzNPOzT2_YLHVkHe3tLFviks5sXMemgaJpZM4FQ0QA .

[stuartbuchanan]

(Try again...)

Could you use the following perhaps?

once /test/property -1 /test/property 0 /test/property 0

Because it's of type "once", it should trigger each time the property changes to one of the values.

I haven't tested it myself, but it might work :)

-Stuart

On Wed, Aug 16, 2017 at 9:01 PM, Stuart Buchanan [email protected] wrote:

Hi All,

Could you use the following perhaps?

<

On Fri, Aug 11, 2017 at 10:29 PM, onox [email protected] wrote:

Many of the properties are integers with values like -1, 0, 1.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/c172p-team/c172p-detailed/issues/362#issuecomment-321923388, or mute the thread https://github.com/notifications/unsubscribe-auth/AL4umOKyt3yzNPOzT2_YLHVkHe3tLFviks5sXMemgaJpZM4FQ0QA .

[onox]

@stuartbuchanan I think you need multiple sound elements each with an <equals> condition. But it's a lot of code for something that is supposed to be simple.

an "in-transit-trigger" mode which should work like in-transit except it just plays the sound till the end instead of stopping immediately (which is the case for non-floats).

I see this a lot with cockpit switches/knobs/dials in FG. Most cockpits have similar types (2-state switches, 3-state switches, n-state knobs, continuous dials, etc.) but a lot of code is needed to provide tooltips, sounds, and smooth animations. The knob animation helps a lot, but it's not enough. Implementing a switch/knob/dial should be and could be much simpler IMHO.