Noteslify icon indicating copy to clipboard operation
Noteslify copied to clipboard

🐛 [BUG] - Max-width in the layout

Open nirajpdn opened this issue 3 years ago • 13 comments
trafficstars

Description

In wider screen the layout is not good as expected design wise and the components in the navbar and footer are not aligned properly. So, max-width can be a better to use.

Reproduction URL

https://noteslify.stonecss.com

Reproduction steps

1. Go to `https://noteslify.stonecss.com`
2. Decrease the browser zoom

Screenshots

![Navbar](https://user-images.githubusercontent.com/59108522/197906634-eadcbcba-199b-4778-85a2-75e757dd8777.png)

![Footer](https://user-images.githubusercontent.com/59108522/197906742-e28c2829-d63f-4007-afa7-1bd62e151203.png)

Logs

No response

Browsers

Chrome

OS

Mac

nirajpdn avatar Oct 26 '22 00:10 nirajpdn

Hey @nirajpdn, Thanks for contributing and Congrats on opening Issue :tada:

We will try to review as soon as possible and a maintainer will get back to you soon!

github-actions[bot] avatar Oct 26 '22 00:10 github-actions[bot]

Thanks For Notifying!! Would you like to contribute to the same as well?

devarshishimpi avatar Oct 26 '22 04:10 devarshishimpi

@devarshishimpi sure. Happy to contribute again.

nirajpdn avatar Oct 26 '22 06:10 nirajpdn

@devarshishimpi sure. Happy to contribute again.

Okay, have assigned

devarshishimpi avatar Oct 26 '22 06:10 devarshishimpi

@nirajpdn Done with the same? Do keep in sync with the repo commits

devarshishimpi avatar Oct 28 '22 07:10 devarshishimpi

@nirajpdn Done with the same? Do keep in sync with the repo commits

I am syncing upstream. Thanks. Will push very soon

nirajpdn avatar Oct 28 '22 08:10 nirajpdn

This issue is already done or are you waiting for something more to do here? Thank you

rbeaujon avatar Oct 28 '22 12:10 rbeaujon

Yep, just apart from specific mobile sizes

devarshishimpi avatar Oct 28 '22 12:10 devarshishimpi

The responsive part is someone working on?

rbeaujon avatar Oct 28 '22 13:10 rbeaujon

No one at the moment

devarshishimpi avatar Oct 28 '22 13:10 devarshishimpi

l'll work on that. Do you have some considerations that I've to take to work on this?

On Fri, Oct 28, 2022 at 4:07 PM Devarshi Shimpi @.***> wrote:

No one at the moment

— Reply to this email directly, view it on GitHub https://github.com/dvstechlabs/Noteslify/issues/186#issuecomment-1294978449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIKHQMGTLXSFSYWJ2RPZ23WFPFXNANCNFSM6AAAAAAROPJBRM . You are receiving this because you commented.Message ID: @.***>

rbeaujon avatar Oct 28 '22 13:10 rbeaujon

Okay, Have assigned you

devarshishimpi avatar Oct 28 '22 13:10 devarshishimpi

Do you have some considerations that I've to take to work on this?

rbeaujon avatar Oct 28 '22 13:10 rbeaujon

Closed

devarshishimpi avatar Jan 06 '23 13:01 devarshishimpi