wit-bindgen icon indicating copy to clipboard operation
wit-bindgen copied to clipboard

Fix the mono runtime test config

Open lewing opened this issue 1 year ago • 8 comments

Update the build to get things working with the latest mono net9 targets

lewing avatar May 29 '24 22:05 lewing

@lewing https://github.com/dotnet/runtime/pull/103881 fixed the conflicting naming error, but now when running wit-bindgen with this PR changes I see this failure csharp_mono_error Because of this I couldn't validate if the fix is enough.

mkhamoyan avatar Jun 26 '24 15:06 mkhamoyan

test result: ok. 27 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 965.25s

need to look at the performance here but csharp-mono tests are green with these changes

lewing avatar Jul 09 '24 16:07 lewing

@dicej with this version I'm seeing errors like

---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)

any thoughts?

lewing avatar Aug 30 '24 16:08 lewing

@dicej with this version I'm seeing errors like

---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)

any thoughts?

haha, I see the problem now. That is what I get for not looking again in the morning before.

lewing avatar Aug 30 '24 16:08 lewing

@dicej with this version I'm seeing errors like

---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)

any thoughts?

As of https://github.com/dotnet/runtime/pull/103752, the *_component_type.o files have been replaced with *_component_type.wit files. Perhaps you're using an older runtime?

dicej avatar Aug 30 '24 16:08 dicej

@dicej with this version I'm seeing errors like

---- variants::run stdout ----
Error: failed to read component type file: VariantsWorld_component_type.o

Caused by:
    The system cannot find the file specified. (os error 2)

any thoughts?

As of dotnet/runtime#103752, the *_component_type.o files have been replaced with *_component_type.wit files. Perhaps you're using an older runtime?

Sadly I was rushing to get it working last night before heading out, I should have looked again this morning. Sorry for the noise.

lewing avatar Aug 30 '24 17:08 lewing

Ok, so it was also very confusing that the features were chained so the native aot test build was writing over the mono tests once the compilation issue was fixed.

the 'NuGet-Migrations failure is not related to these changes .

There do now appear to be a couple of failures on the mono side https://github.com/dotnet/runtime/issues/107212

lewing avatar Aug 30 '24 20:08 lewing

Several of the issues I hit should be fixed in dotnet/runtime main, but it testing that will be challenging until a proper net10 sdk is produced.

lewing avatar Sep 15 '24 20:09 lewing