wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

Stop returning `NOTCAPABLE` errors from WASI calls.

Open sunfishcode opened this issue 3 years ago • 1 comments

ENOTCAPABLE was an error code that is used as part of the rights system, from CloudABI. There is a set of flags associated with each file descriptor listing which operations can be performed with the file descriptor, and if an attempt is made to perform an operation with a file descriptor that isn't permitted by its rights flags, it fails with ENOTCAPABLE.

WASI is removing the rights system. For example, WebAssembly/wasi-libc#294 removed support for translating ENOTCAPABLE into POSIX error codes, on the assumption that engines should stop using it.

So as another step to migrating away from the rights system, remove uses of the ENOTCAPABLE error.

sunfishcode avatar Aug 09 '22 20:08 sunfishcode

Subscribe to Label Action

cc @kubkon

This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

github-actions[bot] avatar Aug 09 '22 23:08 github-actions[bot]

Good call, I applied both your suggestions :smile:.

sunfishcode avatar Aug 10 '22 19:08 sunfishcode