Bartlomiej Plotka

Results 708 comments of Bartlomiej Plotka

> We took a while to review this @panpan0000 I am sorry for that. Do you still want to make the changes and have us merge it? If not I...

Now when play with this more, it feels having `--filter` understand resource name (not only kind) would be also a good API (naturally working)

Can you add those replace directives in `po-lint.mod` after failed bingo get? I think they should be done automatically, but that might have failed for some reason?

Thanks! Interesting. I can try fixing `rename` for windows. Sounds like there is some window specific, thanks for sharing!

No, it's a good mention. However we can totally add this after 1.0 (: Added https://github.com/bwplotka/bingo/issues/139 for this.

Sorry for lag, fair questions! If it's special build flags or even tags - this is already supported: https://github.com/bwplotka/bingo#advanced-techniques - however we could make it more easy to use (some...

Bingo's main power is to strongly maintain the tools dependencies in the isolation, in a go.mod. I think having something custom like script/makefile generally means you need more dependencies, and...

Can anyone reproduce with the latest Prometheus? (If you said +1, what version of Prometheus are you running?). We fixed some issues in the past causing similar behaviour.

(Revisiting this during bug scrub) Thanks for those new use cases. So fixing the [index size limitation (due to some int32 used)](https://github.com/prometheus/prometheus/pull/5884) is one way of solving this, but if...

### Acceptance Criteria: * Port similar behaviour of https://github.com/thanos-io/thanos/pull/3410 to Prometheus compaction