Bartlomiej Plotka

Hey, 1. Adding token information to tags, so e.g. logger will use this info as field (if you add logging interceptor). Here is better example in upcoming v2 (https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v2/interceptors/auth/examples_test.go#L41) 2....

Well there is a point in this. If you don't have control over backend, there is no way you can add rate limit there. Thus you might want to rate...

Makes sense. Would be nice to see how much work/code to maintain there is with some PoC MVP, but otherwise would be keen to have it working for both.

Yea. I think with native histograms it would be easier decision. Wonder if it makes sense to be early adopter of native histograms here for this reason cc @beorn7 Otherwise...

Makes sense to me. Customization here would make sense. Perhaps option to specify fields to add would work (with default specifying all)

Thanks for this and sorry for lag. Example was fixed, but I would love those tests! Do you mind rebasing?

I mean PR is not moving, so if you can actually fix it / add test that would be helpful. We need for all, but even one would be helpful...

Sgtm!

Hi, can you check latest tag (https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0-rc.5)? We recommend now to create your own "logging.Logger" implementation, see https://github.com/grpc-ecosystem/go-grpc-middleware/tree/main/interceptors/logging/examples/zap Let me know if you can still repro the problem with this...

I guess you actually found it in new version and fixed, nice! https://github.com/grpc-ecosystem/go-grpc-middleware/pull/565#pullrequestreview-1383162951