Bartlomiej Plotka comments

Results 708 comments of


                                            Bartlomiej Plotka

v2: Please provide (port) grpc_logsettable.SettableLoggerV2 in go-grpc-middleware/v2

I am failing to understand what global grpc Logger has to do with interceptors (even logging interceptor) 🤔 Do you mind giving us TL;DR on how this repo (on `v2`...

v2: Please provide (port) grpc_logsettable.SettableLoggerV2 in go-grpc-middleware/v2

Closing for now, since we didn't hear from you - we can always open, thanks! (:

CUE-based validator?

No response back, so closing, we can always reopen, thanks! (:

v2: Switch `grpclog.Infof` with something non-global

Thanks for the PR, but this is now done, because we decided to remove opentracing completely. It is deprecated (if needed opentracing from v1 can be used) and otherwise users...

`grpc_retry.StreamClientInterceptor` does not pass the correct `"x-retry-attempty"` metadata value

Typo fixed in https://github.com/grpc-ecosystem/go-grpc-middleware/pull/543

Use protobuf v1.0.0 instead of master

I am not sure if dep is still relevant 4 years later, so closing.

Noisy Transport Closing Log again on v1.3.0

Not sure if this is still relevant for `v2`, closing for now, feel free to reopen.

grpc_ctxtags from metadata

This is pretty old and we know have `v2` code with different structure. Let us know if this is still important, we can reopen.

v2: Add failint to avoid not needed imports (e.g v1 packages)

In progress https://github.com/grpc-ecosystem/go-grpc-middleware/pull/543

symbolizer: Wrong order of segments from pprof heap profile flamegraph

Sorry, missed the discussion. It's either HTTP or benchmark --memprofile flag.