react-virtualized icon indicating copy to clipboard operation
react-virtualized copied to clipboard

Issue #1316: ability to set Column width + remove required

Open OnkelTem opened this issue 5 years ago • 5 comments
trafficstars

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • [x] The existing test suites (npm test) all pass
  • [ ] For any new features or bug fixes, both positive and negative test cases have been added
  • [ ] For any new features, documentation has been added
  • [ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • [x] Format your code with prettier (yarn run prettier).
  • [x] Run the Flow typechecks (yarn run typecheck).

See: https://github.com/bvaughn/react-virtualized/issues/1316

This patch changes the following:

  • removes required from Column's width and assigns auto to flex-basis by default;
  • allows to use any string and number value for Column's width.

OnkelTem avatar Dec 27 '19 09:12 OnkelTem

Codecov Report

Merging #1476 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
+ Coverage    94.7%   94.71%   +<.01%     
==========================================
  Files          47       47              
  Lines        1795     1796       +1     
==========================================
+ Hits         1700     1701       +1     
  Misses         95       95
Impacted Files Coverage Δ
source/Table/Column.js 100% <ø> (ø) :arrow_up:
source/Table/Table.js 88.69% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad85acc...f2d49d0. Read the comment docs.

codecov-io avatar Dec 27 '19 09:12 codecov-io

This is a very good change, but it's been six months. Consider merging then updating the documentation later.

Clearmist avatar Jun 08 '20 21:06 Clearmist

Bump

jackHedaya avatar Feb 08 '21 06:02 jackHedaya

double bump

chaim0m avatar May 25 '21 14:05 chaim0m

+1

kasleet avatar Oct 04 '21 14:10 kasleet

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.71%. Comparing base (ad85acc) to head (f2d49d0). Report is 47 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1476   +/-   ##
=======================================
  Coverage   94.70%   94.71%           
=======================================
  Files          47       47           
  Lines        1795     1796    +1     
=======================================
+ Hits         1700     1701    +1     
  Misses         95       95           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 15 '24 08:09 codecov-commenter