react-virtualized
react-virtualized copied to clipboard
Issue #1316: ability to set Column width + remove required
Thanks for contributing to react-virtualized!
Before submitting a pull request, please complete the following checklist:
- [x] The existing test suites (
npm test) all pass - [ ] For any new features or bug fixes, both positive and negative test cases have been added
- [ ] For any new features, documentation has been added
- [ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
- [x] Format your code with prettier (
yarn run prettier). - [x] Run the Flow typechecks (
yarn run typecheck).
See: https://github.com/bvaughn/react-virtualized/issues/1316
This patch changes the following:
- removes required from Column's
widthand assigns auto toflex-basisby default; - allows to use any string and number value for Column's
width.
Codecov Report
Merging #1476 into master will increase coverage by
<.01%. The diff coverage is100%.
@@ Coverage Diff @@
## master #1476 +/- ##
==========================================
+ Coverage 94.7% 94.71% +<.01%
==========================================
Files 47 47
Lines 1795 1796 +1
==========================================
+ Hits 1700 1701 +1
Misses 95 95
| Impacted Files | Coverage Δ | |
|---|---|---|
| source/Table/Column.js | 100% <ø> (ø) |
:arrow_up: |
| source/Table/Table.js | 88.69% <100%> (+0.09%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ad85acc...f2d49d0. Read the comment docs.
This is a very good change, but it's been six months. Consider merging then updating the documentation later.
Bump
double bump
+1
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.71%. Comparing base (
ad85acc) to head (f2d49d0). Report is 47 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #1476 +/- ##
=======================================
Coverage 94.70% 94.71%
=======================================
Files 47 47
Lines 1795 1796 +1
=======================================
+ Hits 1700 1701 +1
Misses 95 95
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.