Roman Schmid
Roman Schmid
Yeah, you're right about that. It's not really consistent… If you want to unify all the extension-points, a PR would be welcome. We'd have to keep the old ones intact...
An argument against a unified extension-point is, that you'll have to create custom extensions for _every_ form you want to treat differently. So without the unified extension-points you could create...
I know… but you could also argue that this is cumbersome and it's easier to just have different methods instead? Personally, I'm more inclined to go the same route as...
I agree that it's currently a bit of a mess. From what I can see in SilverStripe core, there's usually an extension hook in the method that _creates_ the form,...
That would be option 3, where we remove the extension point from the form. Options 1 + 2 will have the extension point within the form constructor for all custom...
I think the main issue here is to determine what Address instance will contain the customer information? The natural reaction would be to use the Shipping-Address, however if somebody specifies...
Some improvements have been made via #518 I think we could even leave it at that for 2.0
There are several flaws with how the Shopping-Cart and Order-Items are updated: - No easy way to display custom messages to the user, other than relying on Exceptions and try/catch...
We need to think about: - A better Cart API with less internal code paths - Order-Item validation: Validation of a single order item - Cart-validation: Validation of the complete...
While trying to update an application so that it runs on Android 11, I've encountered the same issue. With cordova-android 10.x this plugin is no longer required, but somehow corber...