lifecycle icon indicating copy to clipboard operation
lifecycle copied to clipboard

Published 20 hours ago • verified publisher icon buildpacks

Extend Creator Acceptance Tests

Open ekcasey opened this issue 5 years ago • 7 comments

Add acceptance tests for creator.

These can be minimal smoke tests assuming that much of the logic will be covered by the phase-specific acceptance tests.

ekcasey avatar Nov 16 '20 16:11 ekcasey

The tests should run on Linux and Windows. They should cover most command invocations (see Detector & Analyzer as examples) and should include a test of the exit code in case of error (see Detector as an example).

natalieparellano avatar Mar 23 '21 16:03 natalieparellano

Since we're shipping stack buildpacks with 0.12.0, https://github.com/buildpacks/lifecycle/issues/466 might be a better candidate for this milestone.

natalieparellano avatar Apr 05 '21 18:04 natalieparellano

These were introduced in #698 but are currently very only minimal.

natalieparellano avatar Sep 10 '21 18:09 natalieparellano

@natalieparellano may i give it a try

sagnik3788 avatar Jan 19 '24 08:01 sagnik3788

@sagnik3788 sure! We are happy to have your help :)

natalieparellano avatar Jan 19 '24 19:01 natalieparellano

@natalieparellano Creator tests should run on both Linux and Windows however currently, Windows is not supported. Besides addressing Windows support are there any specific tests that we need to extend ?

sagnik3788 avatar Jan 20 '24 22:01 sagnik3788

@sagnik3788 apologies for the slow reply here. At the moment I think it's OK if these tests don't run on Windows. I guess we intended to make the tests more "robust" but beyond that I can't think of any tests that we absolutely must add. It's possible that what we have already is good enough, and we can close this issue

natalieparellano avatar Feb 01 '24 17:02 natalieparellano