ngrx-store-localstorage icon indicating copy to clipboard operation
ngrx-store-localstorage copied to clipboard

Change to use Angular CLI, prettier, create demo app, add e2e tests

Open BBlackwo opened this issue 5 years ago • 6 comments

The following would improve this repo a lot:

  • [X] Change the build to use Angular CLI
  • [X] Swap out TSLint for ESLint
  • [ ] Add prettier using prettier-schematic
    • [ ] Make sure that lint-staged runs prettier and ESLint
    • [ ] Consider changing formatting to 2 spaces (instead of 4) as that is the default
  • [ ] Replace protractor with cypress (using cypress-schematic)
  • [ ] Add a demo app consuming the library and add some e2e tests

BBlackwo avatar Sep 05 '20 06:09 BBlackwo

#186 partially completes this:

  • [X] Change the build to use Angular CLI
  • [X] Swap out TSLint for ESLint

BBlackwo avatar May 20 '21 02:05 BBlackwo

@BBlackwo Anyone working on remaining changes? I'm ready to work on remaining changes.

Please let me know if I can work on this.

Thanks for these library

sheikalthaf avatar Nov 08 '21 03:11 sheikalthaf

Hi Sheik @sheikalthaf,

Would love to have you work on the remaining changes! Let me know if you have any questions or need help.

BBlackwo avatar Nov 08 '21 04:11 BBlackwo

@BBlackwo thanks for the confirmation. Will work on it.

sheikalthaf avatar Nov 08 '21 04:11 sheikalthaf

For setting up Prettier my preference is to use the default options and not even have a config file.

BBlackwo avatar Nov 08 '21 05:11 BBlackwo

@BBlackwo sure will do that 👍🏻

sheikalthaf avatar Nov 08 '21 06:11 sheikalthaf