complete-intro-to-react-v6 icon indicating copy to clipboard operation
complete-intro-to-react-v6 copied to clipboard

Published 20 hours ago • verified publisher icon btholt

[error-boundaries] Redirect isn't working by itself.

Open AbdAllahAbdElFattah13 opened this issue 4 years ago • 0 comments
trafficstars

Since componentDidUpdate won't be called for the 1st render, if any error happens in the first render, it won't get redirection automatically. This is mentioned in the course itself here https://frontendmasters.com/courses/complete-react-v6/redirect-on-error/ @-0:47 seconds.

I can create a PR for a fix (here and in the other repo) in a couple of days once this issue is acknowledged/approved. Let me know.

AbdAllahAbdElFattah13 avatar Aug 14 '21 21:08 AbdAllahAbdElFattah13