json-forms icon indicating copy to clipboard operation
json-forms copied to clipboard

NPM and Bower Submission

Open nileflowers opened this issue 9 years ago • 12 comments

Thank you for this excellent library. What about adding module loading support and publishing it to npm and bower?

nileflowers avatar Jan 07 '16 21:01 nileflowers

Thanks for your kind words @nileflowers! I've already registered it in bower, can it be improved in any way?

I come from the java world, so I need some directions here. Can you give me any hint?

Also, feel free to do it youself and send me a pull request.

idelvall avatar Jan 07 '16 22:01 idelvall

I think I know just enough to get by. Let me try to get the module loading support started in the next couple of days.

I'll keep you posted on my progress.

Thanks!

nileflowers avatar Jan 08 '16 15:01 nileflowers

Great!

idelvall avatar Jan 08 '16 18:01 idelvall

the package.json is missing a version, without it, nom refuses to recognize it as a package.

npm install --save https://github.com/brutusin/json-forms.git                                                                                                  [16-01-21 11:59:00]
npm ERR! addLocal Could not install /var/folders/11/y4k_165n06lg_tn2nb02nbjr0000gn/T/npm-81078-f0bc005d/git-cache-0b28cc08c116a9ae00185274b10f0903/86350eb237305cbab6c33a607560a709d21281db
npm ERR! Darwin 15.2.0
npm ERR! argv "/usr/local/Cellar/node/5.3.0/bin/node" "/usr/local/bin/npm" "install" "--save" "https://github.com/brutusin/json-forms.git"
npm ERR! node v5.3.0
npm ERR! npm  v3.3.12

npm ERR! No version provided in package.json
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     .../npm-debug.log

e110c0 avatar Jan 21 '16 11:01 e110c0

That last comment has been solved by PR https://github.com/brutusin/json-forms/pull/14

idelvall avatar Feb 12 '16 08:02 idelvall

@nileflowers I think this issue has been solved right?

idelvall avatar Feb 12 '16 08:02 idelvall

Sorry @idelvall, @e110c0 for the delay.

@idelvall I think that's needed for sure, but I was thinking more along the lines like you see in my commit that I just pushed. I basically added support so the module could work more seamlessly with the latest-generation module bundlers like webpack and jspm. Basically removing the assumption that it'll always run in a browser.

I am not ready to create a pull request yet because I haven't tested this. I am thinking about running my own manual tests as well as adding tests using a test harness. Haven't gotten to this part yet.

nileflowers avatar Feb 15 '16 15:02 nileflowers

@nileflowers that sounds great!

Yeah, I assumed since the beginning the application being executed in a browser since these were my needs.

I know there is a whole world around node.js, but I am complete newbie in it, so I leave this matter to you.

Thanks mate!

idelvall avatar Feb 15 '16 16:02 idelvall

Hi, 'brutusin-json-forms' is not in the npm registry.

npmjs.com

dawadam avatar Jun 03 '17 14:06 dawadam

Yes @dawadam, this issue is still open. Maybe you can help us and send a PR that solves the issue?

idelvall avatar Jun 07 '17 09:06 idelvall

Hi, is 'brutusin-json-forms' now in the npm registry ?

jselamy avatar Mar 08 '18 21:03 jselamy

@idelvall I think we can't send a PR to add the package to the npm registry.

dawadam avatar Mar 08 '18 21:03 dawadam