abricotine icon indicating copy to clipboard operation
abricotine copied to clipboard

"Open links on click" feature is broken

Open marc-farre opened this issue 3 years ago • 7 comments

With Abricotine 1.1.4 on Ubuntu, SHIFT + click on a link doesn't do anything. It was working in previous versions.

Messages on console when opening a document (no additional message when clicking on a link):

Gtk-Message: 11:28:34.339: Failed to load module "unity-gtk-module"
Gtk-Message: 11:28:34.340: Failed to load module "unity-gtk-module"
libva error: vaGetDriverNameByIndex() failed with unknown libva error, driver_name = (null)
[45609:0928/112834.466046:ERROR:sandbox_linux.cc(377)] InitializeSandbox() called with multiple threads in process gpu-process.
[45609:0928/112837.781966:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[45609:0928/112840.744398:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!
[45609:0928/112851.547284:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 3 times!

Thanks!

marc-farre avatar Sep 28 '22 09:09 marc-farre

This function changed in 1.1.3, but not in 1.1.4.

@funkycram Are you sure this was working with version 1.1.3?

brrd avatar Sep 30 '22 06:09 brrd

No, I'm not sure in which previous version it was working, perhaps before. Thanks!

marc-farre avatar Sep 30 '22 06:09 marc-farre

This regression probably comes from 5648d4b8168cb6df327e01ee022cbbab2fd79750

shell.openPath(path) is supposed to open path in the desktop's default manner. I assume your desktop doesn't route http(s) links to the browser.

@funkycram What is your version of Ubuntu? Are you using Gnome Shell (Ubuntu default) or another DE? Also, can you try the SHIFT + click function with a path to any file on your system (it is supposed to open the file with the default application)?

brrd avatar Sep 30 '22 07:09 brrd

Ubuntu 22.04, default version (Gnome).

SHIFT + click on path to file on the system doesn't work either: image

marc-farre avatar Sep 30 '22 09:09 marc-farre

Ok, thanks. I don't understand what happens. This needs further investigation.

brrd avatar Sep 30 '22 09:09 brrd

I can confirm the bug persists on PopOS! 22.04 LTS

chamaoskurumi avatar Apr 24 '23 09:04 chamaoskurumi

Also seeing this bug on Pop!_OS 22.04 LTS. Is there any other information we can provide that would help find a solution?

jtherrmann avatar Jul 01 '23 11:07 jtherrmann