history.js icon indicating copy to clipboard operation
history.js copied to clipboard

attempted fix for issue #339 - no more including host in hash on IE 8 and 9

Open kontur opened this issue 12 years ago • 4 comments

In Internet Explorer IE8 and IE9 there seems to be a problem that includes the host in the hash.

http://www.example.com/?page=foobar -> http://www.example.com/#http://www.exmaple.com?page=foobar&_suid=123456789
but    
http://www.example.com/directory/?page=foobar -> http://www.example.com/directory/#?page=foobar&_suid=123456789

I noticed that in History.getShortUrl the baseUrl reports "http://www.example.com/" with a trailing slash. Consequently, shortUrl.replace, does not match anything because of the superfluous "/" at the end of baseUrl. Removing the trailing slash fixes the problem, as shortUrl gets returned correctly.

I only applied this to the uncompressed html4+html5 bundle for jquery as I have not used the other library integrations.

kontur avatar Nov 29 '13 14:11 kontur

Merge please.

LiamKarlMitchell avatar Jun 05 '15 03:06 LiamKarlMitchell

Can confirm that this fixes the issue, just experienced this exact URL problem with the host duplicating into the hash.

Fix also works with the uncompressed bundle for native as well.

ryanmcnz avatar Jun 05 '15 03:06 ryanmcnz

Thanks for confirming :+1:

kontur avatar Jun 05 '15 09:06 kontur

I also can confirm this issue, please merge

adlq avatar Sep 11 '15 09:09 adlq