browserpass-extension
browserpass-extension copied to clipboard
browserpass
Keyboard shortcuts on popup not working
Hi,
I'm on archlinux, with Chromium 129.0.6668.100-1
After opening the popup, then I can't get the following shortcuts to work:
| Shortcut | Description | Result |
|---|---|---|
| Ctrl+C | Copy password to clipboard (will clear in 60 seconds) | Doesn't do anything |
| Ctrl+Shift+C | Copy username to clipboard (will clear in 60 seconds) | Opens the devtools |
| Ctrl+G | Open URL in the current tab | Opens the search in page of chromium |
| Ctrl+Shift+G | Open URL in the new tab | Opens the same search in page |
Do I have to do something special for the shortcuts to work?
Apart from that, I can't find a way to close the popup by using the keyboard.
Hi, I don't think you have to do something special - it sounds like the focus is not in the popup, or at least your browser somehow thinks that the focus is on the page rather than inside the popup, and that's why it sends your hotkeys to the chromium rather than to the popup...
Good point about closing the popup using the keyboard, Escape works in FF but not in Chromium apparently :sweat_smile:
I've just tried to open the popup manually instead of using the keyboard shortcut to open it, but the behavior stays the same.
Do you say any way for me to debug it further @maximbaz ?
It's a tricky one :thinking: How about arrows "Up" or "Down", do they scroll items inside popup or also scroll page itself? It's a stretch, but maybe you have some browser extension, that preserves focus? In other words, does it reproduce in a fresh profile?
"Up" and "Down" work, the popup opens with the focus on the input field.
I've tried on a blank profile and I have the same problem.
I'm using the browser extension and the native host provided by arch.
browserpass 3.1.0-2 browserpass-chromium 3.8.0-2
What desktop environment / window manager do you use? Also, could you try if you have the same issue in FF ?
I'm using awesomewm.
I tried the same in FF and I have the same problem.
Maybe I'm not using the shortcuts right, I don't know.
To clarify my problem, I'm going to detail the steps below:
- Open https://miro.com/login/
- Focus on the "Email" field
- Press "Ctrl + Shift + L"
- the browserpass popup appears, with 2 alternative passwords listed
- I press "Ctrl + C", nothing happens. "Ctrl + Shift + C" opens the Developer Tools.
Thank you for your help @maximbaz .
Your steps look good, the only possible idea I currently have is that this is somehow related to awesomewm, that it steals the focus from popup :thinking: Do you have a chance to try in sway or something else?
I've tried on openbox with Xephyr, and I have the same problem.
I really don't have the impression that the focus is being stolen because the up/down arrows work and "enter" works as well.
Maybe I should try and install the native host from another source? Or install the browser extension from the Chrome Web Store instead of the arch repos?
Native host only runs when there's a file-based operation (like to decrypt files), it doesn't control visual aspects like shortcuts. I think the only option really is for you (or whoever else is able to reproduce the issue) to enable debugger, and see what's going on around this line below when you press e.g. Ctrl+C
https://github.com/browserpass/browserpass-extension/blob/aa522ede65030ac0b7151075c866eaa798a6e6e2/src/popup/interface.js#L301