browserify icon indicating copy to clipboard operation
browserify copied to clipboard

update Node.js versions used in Travis CI checks

Open striezel opened this issue 4 years ago • 10 comments

Node.js versions below 10.x are not maintained anymore, so it is probably best to use some newer, still maintained versions. For release cyles of Node.js see the official site: https://nodejs.org/en/about/releases/.

striezel avatar May 09 '21 11:05 striezel

It seems that AppVeyor cannot install Node.js 16 yet: https://ci.appveyor.com/project/browserify/browserify/builds/39074493/job/f56gjo1d8f1odghj Therefore I had to remove Node.js 16 from AppVeyor's build matrix.

striezel avatar May 09 '21 11:05 striezel

@ljharb: Checks with old versions of Node.js fail on Travis and AppVeyor, but that happened on the current commit of the master branch (0ec6e80ec), too. So I guess that is how it is supposed to be.

striezel avatar May 11 '21 22:05 striezel

Since there has been no activity here for almost a week: Is there anything else blocking this PR? Any more change requests? If so, please let me know. Thanks. :)

striezel avatar May 18 '21 00:05 striezel

@ljharb:

LGTM

Good.

Since this pull request has been approved one and a half month ago but it has not been merged yet: Is there anything else to do? If not, can someone merge it please? Thanks. :)

striezel avatar Jul 03 '21 21:07 striezel

@striezel tests are failing on master in node < 4, and altho i reviewed this PR, i don't typically maintain browserify, so it needs to wait for the maintainers.

ljharb avatar Jul 03 '21 21:07 ljharb

@goto-bus-stop or who is currently maintaining browserify: Is there a chance to get a review on the changes?

Is this still relevant after almost a year now?

striezel avatar May 06 '22 23:05 striezel

您的邮件我已收到,会尽快查阅~

mikixing avatar May 06 '22 23:05 mikixing

@ljharb @goto-bus-stop @feross Would dropping 0.10 and 0.12 be up for reconsideration alongside #2070 ?

Split that out to #2071, which does not overlap with this PR.

legobeat avatar Sep 10 '23 01:09 legobeat

Nope, we will continue to support them.

ljharb avatar Sep 10 '23 03:09 ljharb

@striezel tests are failing on master in node < 4, and altho i reviewed this PR, i don't typically maintain browserify, so it needs to wait for the maintainers.

So who is typically maintaining browserify? Should I ping anybody?

As for Node < 4, that versions already failed before that pull request:

Seeing that the Travis CI jobs of the current commit on the master failed for Node.js 4 and older I just assumed they were not supported by browserify anymore.

I'll re-add those old versions then. Not fixing any tests that fail on those old versions, though.

However, there have been no browserify builds on Travis CI for quite a while, and I suppose it might be time to consider a switch, e. g. to GitHub Actions. So part of this PR may not be relevant anymore, and there possibly should also be CI runs for Node.js 18 and 20, too.

striezel avatar Sep 14 '23 21:09 striezel