defold-orthographic icon indicating copy to clipboard operation
defold-orthographic copied to clipboard

[Needs Review] implementing backward compatible follow multi-target

Open dev-masih opened this issue 6 years ago • 4 comments
trafficstars

So what I did was move target tables to camera module instead of camera script but kept target properties inside camera script because removing it cases a big compatibility issue (forcing devs to select follow target only with code). but the value of this property ignores and inside camera script init function it's value will be sent to targets that's inside camera module. the only issue is if someone changes the target property directly in the middle of the game with go property instead of using follow function call or msg, the changed value will not affect anything

and it needs a better example implementation

dev-masih avatar Nov 07 '19 09:11 dev-masih

I like the idea and the implementation makes sense I think. Do you have any additional thoughts or any concerns with the proposed solution?

britzl avatar Nov 11 '19 20:11 britzl

I like the idea and the implementation makes sense I think. Do you have any additional thoughts or any concerns with the proposed solution?

not until table support for go property gets added to the engine. and the multi-target i think needs a better example inside allfeature (maybe an extra button) and parts of doc needs fixing

dev-masih avatar Nov 12 '19 04:11 dev-masih

@britzl if you think this implementation is fine, tell me so that i begin to fix example and docs

dev-masih avatar Nov 13 '19 16:11 dev-masih

@dev-masih Yes, I like it. Please go ahead!

britzl avatar Nov 17 '19 13:11 britzl