ExoMedia icon indicating copy to clipboard operation
ExoMedia copied to clipboard

Subtitle support

Open bogab opened this issue 9 years ago • 15 comments
trafficstars

Hi @brianwernick , Do you support srt subtitle rendering?

bogab avatar Feb 21 '16 21:02 bogab

Not currently, though this is something that should probably be slated for the 3.x track

brianwernick avatar Feb 21 '16 22:02 brianwernick

Any time frame when this will be released?

bogab avatar Feb 22 '16 07:02 bogab

Sadly no. I've been pretty busy with work lately and since this will be after the 3.0 release I can't say for certain.

brianwernick avatar Feb 22 '16 16:02 brianwernick

An initial implementation has been added in https://github.com/brianwernick/ExoMedia/tree/issue-115_subtitle_callbacks however I would like to to 2 things before it is merged:

  1. Abstract the listener away from the ExoPlayer implementation of Cue
  2. Add support for TimedTextListener for the MediaPlayer instances (only for API 16+)

Adding something like subtitle support is quite a large task but I hope to get it implemented (at least with a basic level) for the 3.1 release

brianwernick avatar Sep 24 '16 19:09 brianwernick

Hi Brian. Do you support subtitle in 3.0.5 release ?

mirjafarabedi avatar Oct 28 '16 18:10 mirjafarabedi

Any news on this? Would love to have this functionality.

ntsik avatar Mar 13 '17 13:03 ntsik

I haven't had time to work on ExoMedia much lately so this will most likely be in a post 4.0 release

brianwernick avatar Mar 13 '17 16:03 brianwernick

can't wait!! i'd love to have it too :)

jboisjo avatar Mar 31 '17 17:03 jboisjo

I'm testing with a HLS with integrated subtitles, firstly i did not get any callback onCues, but currently i'm able to get text from the onCues implementation (the listeners are all right ☺). What i've got to do the trick is at the constructor of EmExoplayer, by modifyng as follows:

player.setSelectedTrack(RENDER_TIMED_METADATA, RENDER_TIMED_METADATA);

I'd like more info about the way to get the subtitle track of a available language to keep developing on it. Thanks for this branch!!

billyjoker avatar May 18 '17 11:05 billyjoker

Any news on that Brian ? :)

Thank you!!

jboisjo avatar Jul 10 '17 02:07 jboisjo

@brianwernick does the video support closed caption/subtitle now?

juliafu1 avatar May 15 '18 19:05 juliafu1

Do you have news of subtitle support srt / closed caption? The work you are doing is fantastic.

vannestf avatar Aug 28 '18 00:08 vannestf

Sadly I have no additional news on the progress of sub/cc (or 5.0 in general) :(

brianwernick avatar Aug 29 '18 13:08 brianwernick

Is there a chance that we can donate for this request to have priority?

Thanks!

netomx avatar Aug 30 '18 15:08 netomx

There is now a sample in the demo app on how to get closed captions for video playback. See Commit c0f4bc3

hansenji avatar Nov 19 '18 18:11 hansenji