Brian Quinlan

Results 187 comments of Brian Quinlan
trafficstars

No worries but I'll be out for the next two weeks so I'll remove myself as a reviewer.

FWIW, the Python approach is to download the entire mappings directory and then choose what encodings to build: https://github.com/python/cpython/blob/6f09f69b7f85962f66d10637c3325bbb2b2d9853/Tools/unicode/Makefile#L23

@jakemac53 > These versions do not yet look to be published, can we wait to land this until we are sure we are actually compatible? > > If you just...

> Note that it is perfectly safe to publish with overridden dev dependencies, they do not affect your users (and in general, dependency_overrides do not affect your users, they are...

The plan is to release the following in rapid succession: * package:web_socket_channel 3.0: removes WebSocketChannel constructor * package:shelf_web_socket 2.0: doesn't use WebSocketChannel constructor, allow web_socket_channel >= 2 < 4 *...

> > Does this package autopublish? I don't understand the validation failure. > > It publishes based on tags - but because of our pinned deps we have to ignore...

Right. So when is a good time for me to publish `shelf_web_socket` and `web_socket_channel` such that we can merge this and do a release quickly after? If I release those...

Yes. They have been > A publish on Monday SGTM. > > These have all been running in google3 right? Yes, for almost 3 weeks now.