PerlPowerTools
PerlPowerTools copied to clipboard
Update packer and PerlPowerTools.exe
Hello Brian,
I'm catching up with this topic after a very long break.
There are a few changes from 2022 for which I've never submitted a PR. It's a massive simplification
plus improvements and bugfixes, and it would make perlpowertools.exe feature complete (I think).
List of changes :
- Only Windows is supported, to limit scope (it doesn't really make sense for other platforms anyway).
- The helper script
bin\perlpowertoolsis standalone (not generated), with dynamic tools list. - With option
-V,bin\perlpowertoolswill display the version of PerlPowerTools module itself. - The packer script
packer\packer.plhas been moved and renamed asutil\packer. - Perldoc's POD is now included in the package, meaning this works :
perlpowertools.exe perldoc perldoc. - Bugfixes
- Basic tests specific to the packer and helper scripts in
t/perlpowertools/(I'm not sure it's the right place). - Rough documentation in
README_PerlPowerTools.exe.pod.
List of changes to other tools in bin:
- Modulinos need the following patch
run() if !caller() || caller(0) eq 'PAR' || caller(1) eq 'PAR'. I've already patched the following tools :date,echo,factor,glob,units.
Future work :
- If the modulinos changes are accepted, document it somewhere. Maybe also in PROGRAMMING_STYLE.md?
- The documentation needs to be improved and must explain how to build your own custom executable, what is PAR::Packer and its startup process (unzip). Problems with antivirus software. POD missing in
packer(but usage ok). - Issues with $0. Some tools in
binmight need review/patch. See notes inpackerheader.
Should I raise one (or more) PR for this?
Thank you and best regards.
Yes, let's start with a new PR. Your plan looks really good.
To answer some questions:
- Modulinos are fine (and maybe even preferred). A patch to PROGRAMMING_STYLE.md would be nice. You can open a separate issue/PR for that if you like.
- I don't know what needs to happen to document this, but if you start it, I'll go through the instructions to test it.
- We have started work to get away from $0 (or use it once). If you need something for your stuff to work, let me know and we'll see how we can get it done.
- [x] Let's make the fixes to the
callerstuff in separate PRs. We can do that now and things should keep working. We don't need to wait to apply those.
Hello Brian, I've open pull request https://github.com/briandfoy/PerlPowerTools/pull/570 with points 1-9, 11 from my initial post.
This is not really "rejected", just moved to its own repo. See #96 and the new repository https://github.com/kal247/perlpowertools-exe where this idea will go forward without worrying about what's going on here.