bree
bree copied to clipboard
[fix] Missing await on 'start' function.
trafficstars
Describe the bug
Node.js version: 18.16
OS version: Win11 (WSL)
Description:
The bug is on the start function, when calling start on already started project, the app will fail and the error can't be cached by try /catch statement, that is because the this.start(job.name) no are waiting...
a good enough solution maybe as call await Promise.all([...]) or just add a await inside the for
async start(name) {
...
for (const job of this.config.jobs) {
this.start(job.name);
}
}
Code to reproduce
(async () => {
....
await bree.add('boop');
await bree.start()
....
await bree.add('foo');
try {
await bree.start()
catch (err) {
// Never call this catch but
}
})();
Checklist
- [X] I have searched through GitHub issues for similar issues.
- [X] I have completely read through the README and documentation.
- [X] I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.