pldb icon indicating copy to clipboard operation
pldb copied to clipboard

Hard coded year values

Open celtic-coder opened this issue 2 years ago • 1 comments

Hi Breck (@breck7),

On the About page in the Citation section, the year is hardcoded:

citation-year

Perhaps, something like replaceJs (as in line #32 of about.scroll) could be used for the year:

replaceJs-example

Just use a variable like CURRENT_YEAR with the appropriate JavaScript code?

The Citation section also appears in the main Readme Scroll (lines 58-71):

citation-in-main-readme

Could this be moved out into a separate file and then use import wherever it is required?

The one other place that I noticed a hard coded year value is in line 35 of Awis.ts crawler:

const-year-in-awis-ts

Again, could this possibly be replaced by some global variable or does it need to be year specific?

Kind Regards, Liam

celtic-coder avatar Jan 30 '23 17:01 celtic-coder

Hi @celtic-coder ! That's a good point. I was thinking that someone would cite the first year something came out, but you are right it makes more sense to cite the year it was accessed since it is continually updated.

I would accept a pull request on this.

breck7 avatar Jan 31 '23 12:01 breck7