breadboard icon indicating copy to clipboard operation
breadboard copied to clipboard

Published 20 hours ago • verified publisher icon breadboard-ai

954 write tests for cli OpenAPI `import`

Open Mearman opened this issue 1 year ago • 7 comments

https://github.com/breadboard-ai/breadboard/issues/954

Mearman avatar Mar 04 '24 15:03 Mearman

⚠️ No Changeset found

Latest commit: 78e9cb530318c6991631fb1b1d98f8e16ec52774

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 04 '24 15:03 changeset-bot[bot]

@wfaithfull is this complete? if not, shall I split of the async fixes into separate PR

Mearman avatar Mar 05 '24 13:03 Mearman

Let's just call this ready for now, I'd rather work smaller iterations on the code so any further stuff can go on top of this. @PaulKinlan do you want to take a look at this?

wfaithfull avatar Mar 05 '24 15:03 wfaithfull

thanks @Mearman for doing those suggestions for me.

wfaithfull avatar Mar 07 '24 16:03 wfaithfull

Anything we need to do here to get this unblocked?

PaulKinlan avatar Mar 25 '24 22:03 PaulKinlan

Just had some conflicts to fix due to changes in import from main, hopefully this does the trick..

wfaithfull avatar Mar 26 '24 21:03 wfaithfull

@PaulKinlan Heyo! I believe this PR is ready, so would you mind giving it a re-review please? :heart_hands:

TinaNikou avatar Aug 21 '24 09:08 TinaNikou