Always show bookmarks on a new tab page is not working if new tab page shows homepage with a custom url

[ToFab]

Description

You can configure brave to only show bookmarks on a new tab page. If you configure a custom url as your home page the bookmarks will be shown for 1 second until the home page loads. This makes it impossible to access the bookmarks on a new tabpage.

It looks to me that the new blank tabpage is loading and the bookmarks are being displayed as expected. Then navigation occurs to get the custom home page url. This causes brave to conclude that we no longer are on a new tabpage and it should stop displaying the bookmarks.

Steps to Reproduce

1. configure the bookmarks to not to be displayed (burger menu > bookmarks > remove checkmark: show bookmarks)
2. enable "Always show bookmarks on a new tab page" (burger menu > settings > appearance)
3. Settings > new Tab Page > New tab page shows: homepage
4. enable "Show home button" and enter a custom url eg. https://duckduckgo.com
5. Open a new tab page. Notice that the bookmarks are shown until the homepage is loaded.

Actual result:

You will briefly see the bookmarks until custom home page is loaded. When the home page url has loaded the bookmarks are no longer shown

Expected result:

I would have expected the bookmarks to continue to be shown until I navigate to a url that is different from the homepage url

Expected:

Actual:

Reproduces how often:

I can reproduce on several computer every time

Brave version (brave://version info)

Brave 1.39.120 Chromium: 102.0.5005.99 (Official Build) (64-bit) Revision 870f7bcc58dfa811cc68c2186439721385e086d0-refs/branch-heads/5005@{#1125} OS Windows 11 Version 21H2 (Build 22000.675)

Version/Channel Information:

Not tested

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Not tested
• Can you reproduce this issue with the nightly channel? -Not tested

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No
• Does the issue resolve itself when disabling Brave Rewards? No
• Is the issue reproducible on the latest version of Chrome? Not tested

Miscellaneous Information:

Nothing to add

[rebron]

Always show bookmarks on a new tab page doesn't look it's being applied in this use case properly where:

1. users sets new tab page to be homepage, and
2. user setting show bookmarks is turned off (but keeps always show bookmarks on new tab page turned on)

If New Tab page is set to blank page, it works fine and bookmarks bar will still show.

cc: @simonhong

[timothymiller]

Can confirm is still happening

[jorgeroma]

This is still happening.

[Tahir-ops]

is still happening