adblock-rust icon indicating copy to clipboard operation
adblock-rust copied to clipboard

Support other procedural filters

Open ryanbr opened this issue 2 years ago • 6 comments
trafficstars

Coming from the post; https://www.reddit.com/r/brave_browser/comments/13lnfky/does_brave_now_fully_support_procedural_filtering/

https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters

Currently supporting :has

As of 19/05/2023, Popularity of filters in uBO:

Filter Number of filters used
has-text 494
upward 352
xpath 49
matches-css 48
matches-path 7
matches-media 3
matches-attr 2
watch-attr 1

ryanbr avatar May 19 '23 10:05 ryanbr

Just noticed that Brave doesn't support has-text. Would be awesome to have that feature!

laymonage avatar Jul 16 '23 22:07 laymonage

AdGuard lists use :contains() instead of :has-text(), Brave should support both of them.

superlex avatar Sep 22 '23 15:09 superlex

Bumping this issue. It would be great to start supporting these selectors

chris-fj avatar Feb 23 '24 23:02 chris-fj

Any news on this? Facebook ads (video pages or on mobile) are unblocked by the lack of has-text().

Yuki2718 avatar Apr 20 '24 07:04 Yuki2718

In the mean time one can use "Stylebot" to match and hide elements using CSS matching.

CapSel avatar Aug 23 '24 21:08 CapSel

Thanks for the suggestion. However, I’m wondering what can StyleBot do that uBlock can’t, because having to install an extension kind of defeats the purpose of having a built-in adblocker. Specially for my use case, where I wanted to do the blocking on an iPhone on which I can’t install any extensions.

On Aug 23, 2024 at 11:38 PM, <CapSel @.***)> wrote:

In the mean time one can use "Stylebot" to match and hide elements using CSS matching.

— Reply to this email directly, view it on GitHub (https://github.com/brave/adblock-rust/issues/293#issuecomment-2307842942), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ABQMROUBAKLOCZDMN7KN7ADZS6TTXAVCNFSM6AAAAAAYHTBWTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHA2DEOJUGI). You are receiving this because you commented.Message ID: @.***>

chris-fj avatar Aug 23 '24 22:08 chris-fj

Added as of https://github.com/brave/adblock-rust/pull/388

antonok-edm avatar Nov 21 '24 19:11 antonok-edm