video-transcoder icon indicating copy to clipboard operation
video-transcoder copied to clipboard

Add rotate video option

Open VGumbakis opened this issue 6 years ago • 3 comments

VGumbakis avatar Jan 28 '19 19:01 VGumbakis

I've just installed the app today in the hope it did rotations, alas it doesn't. Sometimes I end up with videos with wrong orientation for some reason.

Is it just a case of calling ffmpeg with the right parameters?

NuxRo avatar Jun 09 '19 11:06 NuxRo

The the app is basically a wrapper for ffmpeg, it is often "just a case of calling ffmpeg with the right parameters" (:

My understanding is the following would need to be done to get rotation working:

  • Determine arguments for ffmpeg to rotate video
  • Add UI options
    • Determine if there are limits on what rotations can be accepted. 90/180/270 degrees, or arbitrary?
  • Determine how to rotate the preview
    • The preview function will likely need to be redone, as it currently uses a built-in VideoView that only plays a given video. It is currently used to play certain parts of the video to account for cutting the video.
  • Add an option to the app's intent interface so that other apps can also request videos be converted with rotation
  • Add automated tests to cover video rotation

brarcher avatar Jun 09 '19 18:06 brarcher

Ok, sounds like a big job :)

NuxRo avatar Jun 12 '19 13:06 NuxRo