Brandon Roberts

Results 193 comments of Brandon Roberts
trafficstars

@danielroe I took a different approach and just override the entry filename explicitly because the prerenderer is being built internally. Let me know if you have another recommended approach.

> Nice find! I think we can move the default rollup config to the [pretender preset](https://github.com/unjs/nitro/blob/main/src/presets/_nitro/nitro-prerender.ts). Cool, done!

That approach broke 3 test suites tests where the preset is already overriding the entryFileNames property in combination with custom serverDir and output options. I'll take another look

Should be sorted out now. I needed to use the produced `nitrorenderer` config to build the server filename dynamically.

I refuse to support any effort to reduce boilerplate ... But I digress 😄 It looks good to me, but I think `protectedState: true` would be a better name and...

@danielglejzner as @markostanimirovic mentioned, we are looking for feedback, positive and negative, about the technical details of the RFC. Not just comments for the sake of social media engagement. Either...

@tayambamwanza initially, the application schematic was different enough to make a whole new one. We could look at using a combination of the `@nx/angular:application` schematic and running our `init` schematic...

The formatting on some of the code snippets is a little off, but I think in general its ready to be merged, and we can follow up with additional PRs...

I've noticed this also. Its something to do with the wrapper around the vite builder. Pressing CTRL+C twice stops it.