Bram

Results 45 comments of Bram

1. The docs: ok,you did document some of it so I wasn't sure how extensive you wanted the docs so I just added a comment when I spotted something. Not...

> @bram-perl fwiw i can see some issues where the commit messages are a little out of sync with the contents. ill fix that today and repush. ok, just let...

It's looking good, there are some minor changes I would still do (moving things from one commit to another); but rather then burden you with them I did these myself...

one thing to consider (that I did not change): updateAUTHORS.pl in it's final version contains: ``` sub main { .... my $changed= $self->read_and_update(); ... return $changed; # 0 means nothing...

> Thanks for the feedback and commits. Ill review them and the instructions you left and get them merged up. If you should run into troubles let me know (or...

> BTW the test fails are because I didnt realize the tests were run under a shallow clone. Not sure what I can do about that except skip them in...

A shallow clone can be detected by checking: `git rev-parse --is-shallow-repository` or by checking if the file `.git/shallow` exists. Note that the `git rev-parse` needs a recent enough version of...

> A shallow clone can be detected by checking Just a heads up: I'm working on a PR for this (#20124) because CI runs for PRs are currently red (since...

For the " XSLoader.t: fix local skip() implementation" commit: can you specify in the commit message what was wrong and what it fixed? (Looking at the code I do see...

Are you sure this is about LC_ALL that is causing it? What I noticed is that you are using `export LC_PAPER=en_US.UTF-8@letter`; can you try without setting "LC_PAPER"? (I can sort...