header-footer-elementor icon indicating copy to clipboard operation
header-footer-elementor copied to clipboard

Fatal error with version 1.6.30

Open Elisa8321 opened this issue 1 year ago • 21 comments
trafficstars

Describe the bug:

After getting a fatal error with version 1.6.29 I updated to 1.6.30 but it triggers a fatal error anyway..and I get this message: An error of type E_COMPILE_ERROR was caused in line 16 of the file /homepages/12/d495428187/htdocs/app497430624/wp-content/plugins/header-footer-elementor/inc/lib/svg-sanitizer/src/Sanitizer.php. Error message: Cannot declare class enshrined\svgSanitize\Sanitizer, because the name is already in use

With version 1.6.29 it was something in line 32 causing a compile error

WordPress version:

6.5.3

Elementor version:

3.21.5

Elisa8321 avatar May 14 '24 14:05 Elisa8321

+1 also getting this issue

themuddfamily avatar May 14 '24 14:05 themuddfamily

The current situation is very unfortunate. I noticed the bug this morning when I wanted to set up a new instance for a customer and received the said error on the 32 line with version 1.6.29.

Fortunately, I was able to fall back to version 1.6.28 on an alternative instance that I had set up yesterday.

Let's hope that the bug can be completely fixed with 1.6.31.

If permitted, I can also upload the .zip for version 1.6.28 here.

bellottidesign avatar May 14 '24 14:05 bellottidesign

If permitted, I can also upload the .zip for version 1.6.28 here.

you can always download older versions at the normal plugin page: https://wordpress.org/plugins/header-footer-elementor/advanced/ (at the bottom). No need to upload ZIP files here

m1ga avatar May 14 '24 14:05 m1ga

I did the exact same thing. My site was dead, so I rolled back to 1.6.28 and all was well again. So we'll just wait for 1.6.30 and it's not a big deal (as I haven't read the release notes to see what was updated, but 28 currently works fine for me). Cheers.

PeculiarHead avatar May 14 '24 14:05 PeculiarHead

https://github.com/brainstormforce/header-footer-elementor/pull/811 will hopefully fix all issues. Perhaps they'll test it this time :wink:

m1ga avatar May 14 '24 14:05 m1ga

I did the exact same thing. My site was dead, so I rolled back to 1.6.28 and all was well again. So we'll just wait for 1.6.30 and it's not a big deal (as I haven't read the release notes to see what was updated, but 28 currently works fine for me). Cheers.

FATAL error is not a big deal? I woke up with a phone call from my client complaining his website is DEAD!!!

0xK3on avatar May 14 '24 15:05 0xK3on

It worked on most of my sites, but I now have this error on one specific site:

Fatal error: Cannot declare class enshrined\svgSanitize\Sanitizer, because the name is already in use in /****/wp-content/plugins/header-footer-elementor/inc/lib/svg-sanitizer/src/Sanitizer.php on line 16

DIRECT DOWNLOAD LINK FOR 1.6.28 https://downloads.wordpress.org/plugin/header-footer-elementor.1.6.28.zip

rchacin avatar May 14 '24 15:05 rchacin

For the fatal error regarding the sanitizer, we are providing a zip file for the fix v1.6.30. Here is the link to the zip: header-footer-elementor.zip

Can you please verify if it's working as expected, as we are unable to replicate it on our end. Could you please provide the versions of your PHP, WordPress, Elementor and any other dependent plugin on the site so that we can investigate further?

vijetaR avatar May 14 '24 15:05 vijetaR

For the fatal error regarding the sanitizer, we are providing a zip file for the fix v1.6.30. Here is the link to the zip: header-footer-elementor.zip

Can you please verify if it's working as expected, as we are unable to replicate it on our end.

Yes..! It's working for me! THX

rchacin avatar May 14 '24 15:05 rchacin

@rchacin are you using any other svg plugin like svg-support? As that is using svgSanitize too. Maybe that is something to test @vijetaR

m1ga avatar May 14 '24 15:05 m1ga

@rchacin are you using any other svg plugin like svg-support? As that is using svgSanitize too. Maybe that is something to test @vijetaR

That is absolutely right. I'm using WP SVG Images on the particular site that was failing.

I ALSO WENT BACK TO THE v1.6.30 (Without fix), and the site loaded fine after disabling WP SVG Images.

rchacin avatar May 14 '24 15:05 rchacin

@vijetaR You can just add the svg support plugin to replicate it on your end. The provided file fixed the issue. Can you please make sure this does not happen again in the next update. I just spent hours manually updating over 50 websites.

digimarkup avatar May 15 '24 04:05 digimarkup

Same issue here, sightly different error message:

PHP Fatal error:  Cannot declare class enshrined\svgSanitize\Sanitizer, because the name is already in use in /bitnami/ │
│ 202.61.241.62 - - [15/May/2024:06:32:43 +0000] "GET /wp-login.php HTTP/1.1"

Using the bitnami wp helm chart for deployment.

Auto-update brought our WP site down, only fix was to manually move the plugin out of wp-content/plugins and then re-install the reverted version.

What caused the issue exactly? That was a surprise to find our page down this morning ;)

tbscode avatar May 15 '24 07:05 tbscode

Hello,

I have the same problem but since i'm on wordpress.com I cant restore a previous version. My dashboard on wordpress won't let me access the plugins, or the versions of the plugins (it can't even see the plugins that were installed!!) and I can't even see the theme or do anything about it ! Can someone please help me ?

Elodie12345 avatar May 15 '24 07:05 Elodie12345

Hi,

just go here: https://wordpress.org/plugins/header-footer-elementor/advanced/ and at the bottom of the page you can choose which version you would like to download (1.6.28 fixed the issue yesterday for me). Then you can install it manually on wordpress (add new plugin, upload .zip file).

They just released version 1.6.31 and it works for me.

Elisa

Il giorno 15 mag 2024, alle ore 09:22, Elodie12345 @.***> ha scritto:

Hello,

I have the same problem but since i'm on wordpress.com I cant restore a previous version. My dashboard on wordpress won't let me access the plugins, or the versions of the plugins (it can't even see the plugins that were installed!!) and I can't even see the theme or do anything about it ! Can someone please help me ?

— Reply to this email directly, view it on GitHub https://github.com/brainstormforce/header-footer-elementor/issues/810#issuecomment-2111770295, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIPT7T7S4TFW7WOFZJRDIG3ZCMENHAVCNFSM6AAAAABHWKMVD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRG43TAMRZGU. You are receiving this because you authored the thread.

Elisa8321 avatar May 15 '24 07:05 Elisa8321

Don't you test your plugin at all before you roll out to millions of websites?!

Yesterday, auto-update to 1.6.29 broke our website, because include to vendor/autoload.php failed, because this file is not existing. Commented out and waited for the hotfox 1.6.30 to come.

Today, auto-update to 1.6.30 and page down again, because of a conflict with class Sanitizer.

Luckily, I know how to look at PHP error logs and comment out the code pieces which are faulty. But other wordpress website owners do not have that experience and will have a broken site which they cannot login to anymore.

I am a software developer myself and I know that bugs do happen. But such trivial bugs could have been detected by just testing the thing or by running tools like PHPstan to detect mistakes like including files which are not existing.

I will disable auto-update now.

danielmarschall avatar May 15 '24 08:05 danielmarschall

Don't you test your plugin at all before you roll out to millions of websites?!

Yesterday, auto-update to 1.6.29 broke our website, because include to vendor/autoload.php failed, because this file is not existing. Commented out and waited for the hotfox 1.6.30 to come.

Today, auto-update to 1.6.30 and page down again, because of a conflict with class Sanitizer.

Luckily, I know how to look at PHP error logs and comment out the code pieces which are faulty. But other wordpress website owners do not have that experience and will have a broken site which they cannot login to anymore.

I am a software developer myself and I know that bugs do happen. But such trivial bugs could have been detected by just testing the thing or by running tools like PHPstan to detect mistakes like including files which are not existing.

I will disable auto-update now.

Im very surprised this happened, if you look at the commits list the automated tests failed on the merge that caused it, thats when they should have caught this... even if they aren't testing manually this should be sending them an email saying testing failed!

themuddfamily avatar May 15 '24 08:05 themuddfamily

Hello,

We apologize for the inconvenience that has been caused by the recent issues – "Error messages during plugin activation" and the "Conflict with WP SVG Images plugin". We are pleased to inform you that we have released an update to fix the issues.

Please update the plugin to the latest version 1.6.31 to resolve the issues.

Thank you for your understanding and patience. If you have any further questions or encounter any issues, please let us know.

vijetaR avatar May 16 '24 07:05 vijetaR

can anyone confirm if 1.6.31 is already working? I'm about to rollback to 1.6.28

juanpahv avatar May 16 '24 16:05 juanpahv

Yes, no issues with .31

Enviado desde mi dispositivo móvil

On Thu, May 16, 2024, 12:44 PM Juan Pablo Hernández < @.***> wrote:

can anyone confirm if 1.6.31 is already working? I'm about to rollback to 1.6.28

— Reply to this email directly, view it on GitHub https://github.com/brainstormforce/header-footer-elementor/issues/810#issuecomment-2115742242, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFFXXDRH2H5NZ4KRJFBJOTZCTO5XAVCNFSM6AAAAABHWKMVD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVG42DEMRUGI . You are receiving this because you were mentioned.Message ID: @.***>

rchacin avatar May 16 '24 16:05 rchacin

Hello Everyone, The current plugin version is 1.6.34 So, I would suggest you to update the EHFB plugin to the latest version to resolve the issue. Thanks for understanding!

vijetaR avatar May 24 '24 06:05 vijetaR

Hello Everyone,

Thank you for your patience.

As we haven't received any activity on this issue recently, we are closing this ticket for now. If you still need assistance or have any further questions, please feel free to reopen this ticket or create a new one.

Thank you for your understanding.

vijetaR avatar Jun 17 '24 14:06 vijetaR