DPP icon indicating copy to clipboard operation
DPP copied to clipboard

docs: Remove coroutine/DPP_CORO experimental warnings

Open DJOetzi opened this issue 1 year ago • 2 comments
trafficstars

Removed notices of coroutines being an experimental feature.

Documentation change checklist

  • [x] My documentation changes follow the docs style guide and any code examples follow the coding style guide.
  • [x] I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • [x] I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • [x] I have not generated content using AI or a desktop utility such as grammarly.

DJOetzi avatar Aug 12 '24 12:08 DJOetzi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 12 '24 12:08 CLAassistant

Deploy Preview for dpp-dev ready!

Name Link
Latest commit 018c3d30ca5e8a944be667daed4f387d6bf74aba
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66f92226046e390008fb64b5
Deploy Preview https://deploy-preview-1221--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 12 '24 12:08 netlify[bot]

Any update on this?

Jaskowicz1 avatar Aug 30 '24 09:08 Jaskowicz1

You're missing

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/job.h#L48

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/async.h#L103

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/library/CMakeLists.txt#L292

(just remove the word "experimental" here, keep the message()). https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/task.h#L87

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/coroutine.h#L67

should I just remove these comments altogether?

DJOetzi avatar Sep 04 '24 15:09 DJOetzi