Brad Fitzpatrick
Brad Fitzpatrick
I thought about it more and I still don't like this. I don't see what problem it solves. Also, a move this big (moving to use setec for configuration management)...
Sounds fine to us.
Go has no built-in rate limiting. If you get broken network connections, they might be real (a peer really did disconnect), or they might be from hitting kernel limits on...
Can anybody reproduce this and investigate?
Oooh, this is a nice surprise! I haven't reviewed it yet (other than a quick skim) but I'm excited.
@vimt, I accidentally closed this issue while trying to rebase this PR. I pushed the wrong branch to it, which GitHub interpreted as a "close" somehow. I created https://github.com/tailscale/tailscale/pull/13037 with...
> cmd/tsidp: funnel support missing verb. See http://go/commit > Fixes ENG-4195 GitHub issues are preferred. They're linked in more places and then GitHub cross-references things. And GitHub is the issue...
Your second commit seems worth pulling out into its own thing and not a "fixup" (see http://go/cleanup which is likely isn't) Got more details on how it can get stuck?
> I can pull this explanation out into an issue and the commit out into a PR, if that sounds good. SGTM