Brad Fitzpatrick

Results 489 comments of Brad Fitzpatrick

(For others who haven't yet encountered this "portable" term in a Windows context: it doesn't mean portable to different operating systems. It means portable as in you can put a...

I did say "basically" :) But yes, I forgot that's included in the "portable" definition too.

@alexelisenko, @yegors, ping. See comments/questions above. I just saw this again when cleaning up PRs and noticed it had stalled.

This PR is lacking DCO (`git commit -s`) but even if that's fixed and the rest of the PR is fine, there are server-side bits that would also need to...

I could merge at least this client-side portion of things but what's going on with this PR's commits? It has 744 commits in it. Looks like the rebase went poorly....

BTW, `ip.String() == controlDv4One.String() || ip.String() == controlDv4Two.String()` is an inefficient (+ allocating) way to compare to netip.Addrs. You can just `==` on them directly.

The newly added tests also fail? ``` --- FAIL: TestDoHIPsOfBase (0.00s) publicdns_test.go:141: DoHIPsOfBase("https://dns.controld.com/hyq3ipr2ct") = [76.76.2.22 76.76.10.22 2a07:a8c0:0:6:7b5b:5949:35ad:0 2a07:a8c1:0:6:7b5b:5949:35ad:0]; want [76.76.2.22 76.76.10.22 2606:1a40:0:6:7b5b:5949:35ad:0 2606:1a40:1:6:7b5b:5949:35ad:0] publicdns_test.go:141: DoHIPsOfBase("https://dns.controld.com/112233445566778899aabbcc") = [76.76.2.22 76.76.10.22 2a07:a8c0:0:ffff:ffff:ffff:ffff:0 2a07:a8c1:0:ffff:ffff:ffff:ffff:0];...

You didn't check that box that maintainers could make changes, so I ended up forking this off into #11659 to fix the git mistakes and commit message and remove the...

This is now mostly merged (except the parts I removed). If you want to send followup changes, please check the git result first.

Not everything is a conspiracy. We did the Mullvad integration because most operating systems really don't like multiple VPN programs running at the same time, fighting over various system settings....