Brad Fitzpatrick

Results 490 comments of Brad Fitzpatrick

I guess "no new dependencies" isn't a great argument when we already depend on intern and its `go4.org/unsafe/assume-no-moving-gc`, so I guess I have no real objections, other than maintenance overhead....

What about `u128.Uint`? It has some nice properties: uint is already a Go type of undefined size. The 128 will always accompany it in its types name to disambiguate the...

In addition to the standard library, a large motivation for the auto-unmapping was wgcfg.IP (a `[16]byte` IP type), but that's now gone. In any case, if we keep the `As16()...

@CaptainXLAB, what I said about bootstrap DNS is still the issue. Turns out NextDNS didn't need that.

Yes. That's expected. But that's just the UI that uses approximately 0% CPU compared to tailscaled.exe, so the reward for converting it is much lower. (We would've done it if...

No, not maphash. The DNS resolver work I did for windows. The DNS resolver dialer now works on all platforms so it's possible to intercept all Go DNS client usage...

Minimal repro demo: ``` bradfitz@book1pro gvisor_repro % cat foo.go package main import ( "fmt" _ "gvisor.dev/gvisor/pkg/cpuid" ) func main() { fmt.Println("hi") } bradfitz@book1pro gvisor_repro % go run foo.go W0731 08:27:20.214213...

Could you just use https://pkg.go.dev/golang.org/x/sys/cpu instead? At least on darwin? /cc @dsnet

I sent https://github.com/google/gvisor/pull/7850 as a proposed workaround for now. /cc @ayushr2 @kevinGC