bpmn-auto-layout icon indicating copy to clipboard operation
bpmn-auto-layout copied to clipboard

Timer Boundary Event lines cross the whole diagram

Open mgleis opened this issue 4 months ago • 19 comments

Hi, you awesome people.

I have several Timer Boundary Events which lead to the same end node (Timeout).

Unfortunately the lines cross the whole diagram.

Is there something you can do about?

Image

example.bpmn.txt

mgleis avatar Aug 06 '25 07:08 mgleis

We are happy to accept contributions fixing this problem. I'd expect the sequence flows to go to the bottom.

barmac avatar Aug 06 '25 07:08 barmac

Thank you for your trust. Unfortunately, I have absolutely no idea where to start...

mgleis avatar Aug 06 '25 11:08 mgleis

@mgleis Good case!

There are two different ways:

  1. use another layout schema with my fork Image

  2. wait bugfix and merging in main repo 😢

Image

IvanTulaev avatar Aug 06 '25 12:08 IvanTulaev

Image

IvanTulaev avatar Aug 06 '25 13:08 IvanTulaev

@mgleis is it good for you?

Image

IvanTulaev avatar Aug 06 '25 14:08 IvanTulaev

@barmac fix of this bug will close #113
But I can't move forward until the previous PRs not merged.

Image

IvanTulaev avatar Aug 06 '25 14:08 IvanTulaev

@IvanTulaev Your tries are better but still lacking... I don't like it if one edge is above the other. You can't tell where the edges go.

Manually I would draw it like this:

Image

Or even better like this:

Image

And ideally I think overlapping lines should be avoided... add slightly shifted edges like this?

Image

mgleis avatar Aug 06 '25 19:08 mgleis

@mgleis, thanks for the good layout case!

The second option can be implemented in my fork. It will look like this:

Image

Unfortunately, the original repository will require a lot of changes 😢 . Practically, the entire system of element placement will be rewritten from scratch.

The third option is a different functionality not related to the location of BPMN nodes. https://github.com/IvanTulaev/bpmn-auto-layout-feat-IvanTulaev/issues/36

IvanTulaev avatar Aug 07 '25 07:08 IvanTulaev

@mgleis, at final will be

Image

IvanTulaev avatar Aug 07 '25 10:08 IvanTulaev

@mgleis, update my repo and demo. You are welcome. tulaev-ivan.ru

Image

IvanTulaev avatar Aug 07 '25 19:08 IvanTulaev

Yeeeeeha! That Looks amazing!

Why are you doing this all in your fork, and why isn't it merged back to this project?

mgleis avatar Aug 07 '25 20:08 mgleis

@mgleis, one screenshot is worth a thousand words 😅

  1. very long reviews
  2. at one point in time it was necessary to move quickly replacing graphViz in process mining project

Image

IvanTulaev avatar Aug 07 '25 21:08 IvanTulaev

Thanks for your work and effort! I'll switch to your fork for now!

mgleis avatar Aug 08 '25 05:08 mgleis

@IvanTulaev hm, your project is incompatible to this project.... I use /index.js to autolayout a bpmn on the command line. I am missing this in your project....

mgleis avatar Aug 08 '25 09:08 mgleis

@mgleis, what did you mean? What kind of cli comand you run? Can you explain?

I use it with testRunner.js file with same content.

Image

IvanTulaev avatar Aug 08 '25 09:08 IvanTulaev

@mgleis can you show your index.js from orinal repo?

if you run it as

node projectFolder/index.js bpmnFilePath

It must carry a payload other than the exported function.

IvanTulaev avatar Aug 08 '25 10:08 IvanTulaev

@IvanTulaev oh, I'm sorry, my fault. It works now, excellent! Thank you so much!

mgleis avatar Aug 08 '25 20:08 mgleis

@barmac Will it be pulled into the main repository in this form? Is it worth making edits? https://github.com/bpmn-io/bpmn-auto-layout/issues/126#issuecomment-3160327962

IvanTulaev avatar Aug 11 '25 20:08 IvanTulaev

It is certainly worth it, but the team is now loaded with other items. We should get to review your contributions within a couple of weeks. Sorry for a delay.

barmac avatar Sep 04 '25 07:09 barmac