bpmn-auto-layout
bpmn-auto-layout copied to clipboard
Timer Boundary Event lines cross the whole diagram
Hi, you awesome people.
I have several Timer Boundary Events which lead to the same end node (Timeout).
Unfortunately the lines cross the whole diagram.
Is there something you can do about?
We are happy to accept contributions fixing this problem. I'd expect the sequence flows to go to the bottom.
Thank you for your trust. Unfortunately, I have absolutely no idea where to start...
@mgleis Good case!
There are two different ways:
-
use another layout schema with my fork
-
wait bugfix and merging in main repo 😢
@mgleis is it good for you?
@barmac fix of this bug will close #113
But I can't move forward until the previous PRs not merged.
@IvanTulaev Your tries are better but still lacking... I don't like it if one edge is above the other. You can't tell where the edges go.
Manually I would draw it like this:
Or even better like this:
And ideally I think overlapping lines should be avoided... add slightly shifted edges like this?
@mgleis, thanks for the good layout case!
The second option can be implemented in my fork. It will look like this:
Unfortunately, the original repository will require a lot of changes 😢 . Practically, the entire system of element placement will be rewritten from scratch.
The third option is a different functionality not related to the location of BPMN nodes. https://github.com/IvanTulaev/bpmn-auto-layout-feat-IvanTulaev/issues/36
@mgleis, at final will be
@mgleis, update my repo and demo. You are welcome. tulaev-ivan.ru
Yeeeeeha! That Looks amazing!
Why are you doing this all in your fork, and why isn't it merged back to this project?
@mgleis, one screenshot is worth a thousand words 😅
- very long reviews
- at one point in time it was necessary to move quickly replacing graphViz in process mining project
Thanks for your work and effort! I'll switch to your fork for now!
@IvanTulaev hm, your project is incompatible to this project.... I use /index.js to autolayout a bpmn on the command line. I am missing this in your project....
@mgleis, what did you mean? What kind of cli comand you run? Can you explain?
I use it with testRunner.js file with same content.
@mgleis can you show your index.js from orinal repo?
if you run it as
node projectFolder/index.js bpmnFilePath
It must carry a payload other than the exported function.
@IvanTulaev oh, I'm sorry, my fault. It works now, excellent! Thank you so much!
@barmac Will it be pulled into the main repository in this form? Is it worth making edits? https://github.com/bpmn-io/bpmn-auto-layout/issues/126#issuecomment-3160327962
It is certainly worth it, but the team is now loaded with other items. We should get to review your contributions within a couple of weeks. Sorry for a delay.