box2 icon indicating copy to clipboard operation
box2 copied to clipboard

Fix the composer autoloader location for cgr

Open mikeSimonson opened this issue 8 years ago • 4 comments

There is a tool called cgr (for composer global require) that install every tool that needs to be globaly available in their own custom folder. It does so that each tool dependecy don't infuences other tools dependencies.

This means that the logic that was previously used by the autoloader location code for box is broken. For some reason the code used to look for the last autoloader in the folder structure ( the one closest to the root folder ). I have no idea why it was doing so.

For cgr to work it needs to be the first one found that needs to be used. I have changed the logic accordingly in this PR as well as removed some dead code (an option that was never used).

Any comment ?

mikeSimonson avatar Apr 04 '17 13:04 mikeSimonson

Ping @kherge: this actually makes much more sense as you're likely to want the first vendor (which 99% will be your project one) and not the most global one.

theofidry avatar Jun 09 '17 14:06 theofidry

@mikeSimonson see https://github.com/humbug/box/pull/3

theofidry avatar Nov 12 '17 23:11 theofidry

@theofidry Thanks. Is humbug fork the main repo now ?

mikeSimonson avatar Nov 16 '17 09:11 mikeSimonson

@mikeSimonson yeah. Well at least I'm working on it as I couldn't get hold on Keven Herrera to access to this one

theofidry avatar Nov 16 '17 10:11 theofidry