ObjectiveDDP icon indicating copy to clipboard operation
ObjectiveDDP copied to clipboard

SocketRocket Podspec out of date

Open jleach opened this issue 10 years ago • 1 comments

It looks like the commit the SocketRocket Podspec references is quite stale:

commit 82c9f8938f8b9b7aa578866cb7ce56bc11e52ced
Merge: 4313297 facb4d9
Author: Mike Lewis <[email protected]>
Date:   Thu Jun 14 00:29:55 2012 -0700

    Merge pull request #28 from MSch/patch-1

    Only require CFNetwork on iOS so that podspec works on Lion

This reference has a bug in that the delegate in WebSocket.h is using assign rater than weak:

@property (nonatomic, assign) id <SRWebSocketDelegate> delegate;

This can cause EXC_BAD_ACCESS exception of the delegate is freed but called. I can reproduce this by calling login multiple times quickly while disconnected from the server. I've created an issue agains SocketRocket asking for an update: https://github.com/square/SocketRocket/issues/216

_I think SocketRocket is poorly maintained. Might be worth considering a different library._

jleach avatar Jan 21 '15 19:01 jleach

Indeed you are right it isn't getting as much love as it needs, I've got a version of ObjectiveDDP using SocketKit but that library is also quite new and has its own share of issues.

mikey0000 avatar Jan 21 '15 19:01 mikey0000